SolarEdgeClient::getFromSiteWithStartAndEnd() - Code Metrics - Inspection of "[IMPROVMENT] Added a few testcases, code coverage..." - PragmaBroadvertising/laravel-solaredge-api - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3dda6b...0e9ea3 )

by Evert

created 2017-09-27 21:25 UTC

SolarEdgeClient::getFromSiteWithStartAndEnd() A

↳ Parent: SolarEdgeClient

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	16
nc	2
nop	5
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: evert
 * Date: 27/09/2017
 * Time: 09:38
 */

namespace PragmaBroadvertising\SolarEdge\Models;

use Ixudra\Curl\Facades\Curl;
use PragmaBroadvertising\SolarEdge\Interfaces\ApiConnectorInterface;

class SolarEdgeClient implements ApiConnectorInterface
{
    public function __construct()
    {
        $this->key = '?api_key=' . env('SOLAREDGE_API_KEY','');

        $this->id = env('SOLAREDGE_INSTALLATION_ID','');

        $this->endpoint = env('SOLAREDGE_ENDPOINT','https://monitoringapi.solaredge.com/');

    }

    /**
     * Get from Site
     * - endpoint
     * - id
     * - key
     * @param $siteProperty
     * @return mixed
     */
    function getFromSite($siteProperty){

        $request = Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty . $this->key)->asJson()->get()->{$siteProperty};
        return $request;
    }

    /**
     * Get from Site with start- and end date
     * - endpoint
     * - id
     * - key
     * - timeUnit
     * - startDate
     * - endDate
     * - withTime
     * @param $siteProperty
     * @return mixed
     */
    function getFromSiteWithStartAndEnd($siteProperty,$timeUnit,$startDate,$endDate,$withTime = false){

        if(!$withTime) {
            $request =
                Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
                    $this->key .
                    '&startDate=' . $startDate .
                    '&endDate=' . $endDate .
                    '&timeUnit=' . $timeUnit
                )->asJson()->get()->{$siteProperty};
        }
        else {
            $request =
                Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
                    $this->key .
                    '&startTime=' . $startDate .
                    '&endTime=' . $endDate
                )->asJson()->get()->{$siteProperty};
        }

        return $request;
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: evert
5			* Date: 27/09/2017
6			* Time: 09:38
7			*/
8
9			namespace PragmaBroadvertising\SolarEdge\Models;
10
11			use Ixudra\Curl\Facades\Curl;
12			use PragmaBroadvertising\SolarEdge\Interfaces\ApiConnectorInterface;
13
14			class SolarEdgeClient implements ApiConnectorInterface
15			{
16			public function __construct()
17			{
18			$this->key = '?api_key=' . env('SOLAREDGE_API_KEY','');
			0 ignored issues – show Bug Best Practice introduced 2017-09-27 21:27 UTC by Report Bug Copy Issue Report The property `key` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
19			$this->id = env('SOLAREDGE_INSTALLATION_ID','');
			0 ignored issues – show Bug Best Practice introduced 2017-09-27 21:27 UTC by Report Bug Copy Issue Report The property `id` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
20			$this->endpoint = env('SOLAREDGE_ENDPOINT','https://monitoringapi.solaredge.com/');
			0 ignored issues – show Bug Best Practice introduced 2017-09-27 21:27 UTC by Report Bug Copy Issue Report The property `endpoint` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
21			}
22
23			/**
24			* Get from Site
25			* - endpoint
26			* - id
27			* - key
28			* @param $siteProperty
29			* @return mixed
30			*/
31			function getFromSite($siteProperty){
			0 ignored issues – show Best Practice introduced 2017-09-26 08:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
32			$request = Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty . $this->key)->asJson()->get()->{$siteProperty};
33			return $request;
34			}
35
36			/**
37			* Get from Site with start- and end date
38			* - endpoint
39			* - id
40			* - key
41			* - timeUnit
42			* - startDate
43			* - endDate
44			* - withTime
45			* @param $siteProperty
46			* @return mixed
47			*/
48			function getFromSiteWithStartAndEnd($siteProperty,$timeUnit,$startDate,$endDate,$withTime = false){
			0 ignored issues – show Best Practice introduced 2017-09-26 08:19 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
49			if(!$withTime) {
50			$request =
51			Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
52			$this->key .
53			'&startDate=' . $startDate .
54			'&endDate=' . $endDate .
55			'&timeUnit=' . $timeUnit
56			)->asJson()->get()->{$siteProperty};
57			}
58			else {
59			$request =
60			Curl::to($this->endpoint . 'site/' . $this->id . '/' . $siteProperty .
61			$this->key .
62			'&startTime=' . $startDate .
63			'&endTime=' . $endDate
64			)->asJson()->get()->{$siteProperty};
65			}
66
67			return $request;
68			}
69			}

PragmaBroadvertising / laravel-solaredge-api

Push — master ( 3dda6b...0e9ea3 )

SolarEdgeClient::getFromSiteWithStartAndEnd() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like