GoogleAnalytics::googleAnalytics() - Code Metrics - Inspection of "Upgrade to php-cs-fixer 2.3" - PowerKiKi/mqueue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (2d0ab0)

by Adrien

created 2017-06-30 16:38 UTC

GoogleAnalytics::googleAnalytics() B

↳ Parent: GoogleAnalytics

Complexity

Conditions	5
Paths	6

Size

Total Lines	28
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5.025

Importance

Changes

Metric	Value
cc	5
eloc	13
nc	6
nop	1
dl	0
loc	28
ccs	9
cts	10
cp	0.9
crap	5.025
rs	8.439
c	0
b	0
f	0

<?php

namespace mQueue\View\Helper;

use Zend_Application;
use Zend_View_Helper_Abstract;

class GoogleAnalytics extends Zend_View_Helper_Abstract
{
    /**
     * Returns javascript code for Google Analytics
     * @param string $trackingCode

     * @return string
     */
    public function googleAnalytics($trackingCode = null)

    {
        if (!is_string($trackingCode)) {
            global $application;
function myFunction($a, $b) {
    // Do something
}
            if ($application instanceof Zend_Application) {
                $trackingCode = $application->getOption('googleAnalyticsTrackingCode', null);
            }
        }

        $trackingCode = trim($trackingCode);
        if (!is_string($trackingCode) || empty($trackingCode)) {
            return '';
        }

        $result = <<<STRING
<script type="text/javascript">
  (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
  (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
  m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
  })(window,document,'script','//www.google-analytics.com/analytics.js','ga');

  ga('create', '$trackingCode', 'auto');
  ga('send', 'pageview');
</script>
STRING;

        return $result;
    }
}


Branch — master (2d0ab0)

GoogleAnalytics::googleAnalytics() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2
3		namespace mQueue\View\Helper;
4
5		use Zend_Application;
6		use Zend_View_Helper_Abstract;
7
8		class GoogleAnalytics extends Zend_View_Helper_Abstract
9		{
10		/**
11		* Returns javascript code for Google Analytics
12		* @param string $trackingCode
		0 ignored issues – show Documentation introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Should the type for parameter `$trackingCode` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
13		* @return string
14		*/
15	12	public function googleAnalytics($trackingCode = null)
		0 ignored issues – show Coding Style Best Practice introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
16		{
17	12	if (!is_string($trackingCode)) {
18	12	global $application;
		0 ignored issues – show Compatibility Best Practice introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
19	12	if ($application instanceof Zend_Application) {
20	12	$trackingCode = $application->getOption('googleAnalyticsTrackingCode', null);
21		}
22		}
23
24	12	$trackingCode = trim($trackingCode);
25	12	if (!is_string($trackingCode) \|\| empty($trackingCode)) {
26		return '';
27		}
28
29		$result = <<<STRING
30		<script type="text/javascript">
31		(function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]\|\|function(){
32		(i[r].q=i[r].q\|\|[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
33		m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
34		})(window,document,'script','//www.google-analytics.com/analytics.js','ga');
35
36	12	ga('create', '$trackingCode', 'auto');
37		ga('send', 'pageview');
38		</script>
39		STRING;
40
41	12	return $result;
42		}
43		}
44

PowerKiKi / mqueue

Branch — master (2d0ab0)

GoogleAnalytics::googleAnalytics() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like