ActivityControllerTest::assertCommonThings() - Code Metrics - Inspection of "Update PHP deps and add PHPStan" - PowerKiKi/mqueue - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 008819...bd15c6 )

by Adrien

created 2020-04-01 23:45 UTC

ActivityControllerTest::assertCommonThings() A

↳ Parent: ActivityControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

namespace mQueueTest\Controller;

class ActivityControllerTest extends AbstractControllerTestCase
{
    protected function assertCommonThings(array $params): void
    {
        $this->assertModule($params['module']);
        $this->assertController($params['controller']);
        $this->assertAction($params['action']);
    }

    public function testIndexAction(): void
    {
        $params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default'];
        $url = $this->url($this->urlizeOptions($params));
        $this->dispatch($url);

        // assertions
        $this->assertCommonThings($params);

        $this->assertQueryContentContains('h2', 'Overall activity');
    }

    public function testUserAction(): void
    {
        $params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default', 'user' => $this->testUser->id];

        $url = $this->url($this->urlizeOptions($params));
        $this->dispatch($url);

        // assertions
        $this->assertCommonThings($params);

        $this->assertQueryContentContains('h2', 'Activity for');
    }

    public function testMovieAction(): void
    {
        $params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default', 'movie' => $this->movieData['id']];
        $url = $this->url($this->urlizeOptions($params));
        $this->dispatch($url);

        // assertions
        $this->assertCommonThings($params);

        $this->assertQueryContentContains('h2', 'Activity for ' . $this->movieData['title']);
    }
}


1			<?php
2
3			namespace mQueueTest\Controller;
4
5			class ActivityControllerTest extends AbstractControllerTestCase
6			{
7			protected function assertCommonThings(array $params): void
8			{
9			$this->assertModule($params['module']);
10			$this->assertController($params['controller']);
11			$this->assertAction($params['action']);
12			}
13
14			public function testIndexAction(): void
15			{
16			$params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default'];
17			$url = $this->url($this->urlizeOptions($params));
18			$this->dispatch($url);
19
20			// assertions
21			$this->assertCommonThings($params);
22
23			$this->assertQueryContentContains('h2', 'Overall activity');
24			}
25
26			public function testUserAction(): void
27			{
28			$params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default', 'user' => $this->testUser->id];
			0 ignored issues – show Bug Best Practice introduced 2019-06-13 09:00 UTC by Report Bug Copy Issue Report The property `id` does not exist on `mQueue\Model\User`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
29			$url = $this->url($this->urlizeOptions($params));
30			$this->dispatch($url);
31
32			// assertions
33			$this->assertCommonThings($params);
34
35			$this->assertQueryContentContains('h2', 'Activity for');
36			}
37
38			public function testMovieAction(): void
39			{
40			$params = ['action' => 'index', 'controller' => 'activity', 'module' => 'default', 'movie' => $this->movieData['id']];
41			$url = $this->url($this->urlizeOptions($params));
42			$this->dispatch($url);
43
44			// assertions
45			$this->assertCommonThings($params);
46
47			$this->assertQueryContentContains('h2', 'Activity for ' . $this->movieData['title']);
48			}
49			}
50

PowerKiKi / mqueue

Push — master ( 008819...bd15c6 )

ActivityControllerTest::assertCommonThings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like