User - Code Metrics - Inspection of "Avoid one more warning on PHP 7.2" - PowerKiKi/mqueue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cc3347...ae7860 )

by Adrien

created 2018-08-11 11:42 UTC

User A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

94.44%

Importance

Changes

Metric	Value
dl	0
loc	65
rs	10
c	0
b	0
f	0
ccs	17
cts	18
cp	0.9444
wmc	8
lcom	1
cbo	4

4 Methods

Rating	Name	Size	Complexity
A	getCurrent()	13	3
A	setCurrent()	6	2
A	getStatistics()	4	1
A	delete()	8	2

<?php

namespace mQueue\Model;

use mQueue\Model\User as DefaultModelUser;
use Zend_Session_Namespace;

class User extends AbstractModel
{
    /**
     * The current user logged in.
     * -1 before initialization
     * null if no user logged in
     * \mQueue\Model\User if logged in
     *
     * @var \mQueue\Model\User
     */
    private static $currentUser = -1;

    /**
     * Returns the user currently logged in or null
     *
     * @return null|\mQueue\Model\User
     */
    public static function getCurrent()
    {
        if (is_int(self::$currentUser)) {
            $session = new Zend_Session_Namespace();
            if (isset($session->idUser)) {
                self::$currentUser = UserMapper::find($session->idUser);
            } else {
                self::$currentUser = null;
            }
        }

        return self::$currentUser;
    }

    /**
     * Set the user currently logged in, or log him out
     *
     * @param \mQueue\Model\User $user

     */
    public static function setCurrent(DefaultModelUser $user = null): void
    {
        $session = new Zend_Session_Namespace();
        $session->idUser = $user ? $user->id : null;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        self::$currentUser = $user;
    }

    /**
     * Returns movie ratings statistics
     *
     * @return array of count of movies per ratings

     */
    public function getStatistics()
    {
        return StatusMapper::getStatistics($this);
    }

    /**
     * Override parent to auto-logout when deleting logged in user
     */
    public function delete()
    {
        if (DefaultModelUser::getCurrent() == $this) {
            DefaultModelUser::setCurrent(null);
        }

        return parent::delete();
    }
}


1		<?php
2
3		namespace mQueue\Model;
4
5		use mQueue\Model\User as DefaultModelUser;
6		use Zend_Session_Namespace;
7
8		class User extends AbstractModel
9		{
10		/**
11		* The current user logged in.
12		* -1 before initialization
13		* null if no user logged in
14		* \mQueue\Model\User if logged in
15		*
16		* @var \mQueue\Model\User
17		*/
18		private static $currentUser = -1;
19
20		/**
21		* Returns the user currently logged in or null
22		*
23		* @return null\|\mQueue\Model\User
24		*/
25	13	public static function getCurrent()
26		{
27	13	if (is_int(self::$currentUser)) {
28	1	$session = new Zend_Session_Namespace();
29	1	if (isset($session->idUser)) {
30		self::$currentUser = UserMapper::find($session->idUser);
31		} else {
32	1	self::$currentUser = null;
33		}
34		}
35
36	13	return self::$currentUser;
37		}
38
39		/**
40		* Set the user currently logged in, or log him out
41		*
42		* @param \mQueue\Model\User $user
		0 ignored issues – show Documentation introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Should the type for parameter `$user` not be `null\|User`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
43		*/
44	2	public static function setCurrent(DefaultModelUser $user = null): void
45		{
46	2	$session = new Zend_Session_Namespace();
47	2	$session->idUser = $user ? $user->id : null;
		0 ignored issues – show Documentation introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<mQueue\Model\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48	2	self::$currentUser = $user;
49	2	}
50
51		/**
52		* Returns movie ratings statistics
53		*
54		* @return array of count of movies per ratings
		0 ignored issues – show Documentation introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<*,integer>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
55		*/
56	1	public function getStatistics()
57		{
58	1	return StatusMapper::getStatistics($this);
59		}
60
61		/**
62		* Override parent to auto-logout when deleting logged in user
63		*/
64	2	public function delete()
65		{
66	2	if (DefaultModelUser::getCurrent() == $this) {
67	2	DefaultModelUser::setCurrent(null);
68		}
69
70	2	return parent::delete();
71		}
72		}
73

PowerKiKi / mqueue

Push — master ( cc3347...ae7860 )

User A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like