MovieController::importAction() - Code Metrics - Inspection of "Update deps" - PowerKiKi/mqueue - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca1336...ce2897 )

by Adrien

created 2016-08-08 10:12 UTC

MovieController::importAction() C

↳ Parent: MovieController

Complexity

Conditions	10
Paths	20

Size

Total Lines	56
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	10

Importance

Changes	10
Bugs	3	Features	2

Metric	Value
cc	10
eloc	39
c	10
b	3
f	2
nc	20
nop	0
dl	0
loc	56
ccs	7
cts	7
cp	1
crap	10
rs	6.7741

How to fix Long Method Complexity

<?php

class MovieController extends Zend_Controller_Action
namespace YourVendor;

class YourClass { }
{
    public function init()
    {
        // Init the Context Switch Action helper
        $contextSwitch = $this->_helper->contextSwitch();

        // Add the new context
        $contextSwitch->setContexts([
            'csv' => ['suffix' => 'csv'],
            'rss' => ['suffix' => 'rss'],
        ]);

        $contextSwitch->addActionContext('index', 'csv')->addActionContext('index', 'rss')->initContext();
    }

    public function indexAction()
    {
        // Check there is at least one user, otherwise the whole page will crash
        if (!\mQueue\Model\User::getCurrent() && !\mQueue\Model\UserMapper::getDbTable()->fetchRow()) {
            throw new Exception('At least one user must exist to access this page');
        }

        $form = new \mQueue\Form\Filters();
        $this->view->formFilter = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        // Detect if at least one filter was submitted
        $submitted = false;
        foreach ($this->getRequest()->getParams() as $key => $filter) {
            if (preg_match('/^filter\d+$/', $key)) {
                $submitted = true;
            }
        }

        // If was submitted and do not want to clear, try to validate values
        if ($submitted && !$this->_getParam('clear', false)) {
            if (!$form->isValid($this->getRequest()->getParams())) {
                $this->_helper->FlashMessenger(['warning' => _tr('Filter is invalid.')]);
                $form->setDefaults([]);
            }
        }
        // If we submitted a quicksearch, set default values to search with any status
        elseif ($this->_getParam('search')) {
            $form->setDefaults([
                'filter1' => [
                    'user' => \mQueue\Model\User::getCurrent() ? 0 : \mQueue\Model\UserMapper::fetchAll()->current()->id,

                    'status' => -2,
                    'title' => $this->_getParam('search'),
                ],
            ]);
        }
        // Otherwise clear the filter
        else {
            $form->setDefaults([]);
        }

        // Gather users selected in filters
        $this->view->users = [];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $filters = $form->getValues();
        foreach ($filters as $key => $filter) {
            if (!preg_match('/^filter\d+$/', $key)) {
                continue;
            }

            $this->view->users[$filter['user']] = \mQueue\Model\UserMapper::find($filter['user']);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        // If we ouput rss, we force sorting by date
        if ($this->_helper->contextSwitch()->getCurrentContext() == 'rss') {
            $this->getRequest()->setParam('sort', $filters['filter1']['withSource'] ? 'dateSearch' : 'date');
            $this->getRequest()->setParam('sortOrder', 'desc');
        }
        $this->view->permanentParams = $form->getValues();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->filterName = $form->getValuesText();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        unset($this->view->permanentParams['addFilter']);

        $allowedSortingKey = ['title', 'date', 'dateSearch'];
        $usersCount = count($this->view->users);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        for ($i = 0; $i < $usersCount; ++$i) {
            $allowedSortingKey[] = 'status' . $i;
        }
        $sort = $this->_helper->createSorting('sort', $allowedSortingKey);

        // Set up the paginator: Apply pagination only if there is no special context (so it is normal html rendering)
        $this->view->paginator = $this->_helper->createPaginator(\mQueue\Model\MovieMapper::getFilteredQuery($filters, $sort));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function viewAction()

    {
        if ($this->getRequest()->getParam('id')) {
            $this->view->movie = \mQueue\Model\MovieMapper::find($this->getRequest()->getParam('id'));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }

        if (!$this->view->movie) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            throw new Exception($this->view->translate('Movie not found'));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }

        $this->view->users = \mQueue\Model\UserMapper::fetchAll();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        $this->view->movieActivity = $this->_helper->createPaginator(\mQueue\Model\StatusMapper::getActivityQuery($this->view->movie));
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function addAction()
    {
        $request = $this->getRequest();
        $form = new \mQueue\Form\Movie();

        if ($this->_getParam('id')) {
            if ($form->isValid($request->getParams())) {
                $values = $form->getValues();
                $movie = \mQueue\Model\MovieMapper::find(\mQueue\Model\Movie::extractId($values['id']));
                if (!$movie) {
                    $movie = \mQueue\Model\MovieMapper::getDbTable()->createRow();
                    $movie->setId($values['id']);
                    $movie->save();
                    $this->_helper->FlashMessenger(_tr('A movie was added.'));
                }

                $this->view->movies = [$movie];
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            }
        }

        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }

    public function importAction()
    {
        $request = $this->getRequest();
        $form = new \mQueue\Form\Import();
        $form->setDefaults(['favoriteMinimum' => 9, 'excellentMinimum' => 7, 'okMinimum' => 5]);
        $this->view->form = $form;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        if ($this->getRequest()->isPost() && $form->isValid($request->getPost())) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            if (\mQueue\Model\User::getCurrent() == null) {
                $this->_helper->FlashMessenger(['error' => _tr('You must be logged in.')]);

                return;
            }

            $values = $form->getValues();
            $page = file_get_contents($values['url']);

            $pattern = '|<a href="/title/tt(\d{7})/">.*</td>\s*<td.*>(\d+(\.\d)*)</td>|U';
            preg_match_all($pattern, $page, $matches);

            $movies = [];
            $matchesCount = count($matches[1]);
            for ($i = 0; $i < $matchesCount; ++$i) {
                $id = $matches[1][$i];
                $imdbRating = $matches[2][$i];

                $movie = \mQueue\Model\MovieMapper::find($id);
                if (!$movie) {
                    $movie = \mQueue\Model\MovieMapper::getDbTable()->createRow();
                    $movie->setId($id);
                    $movie->save();
                }

                if ($imdbRating >= $values['favoriteMinimum']) {
                    $rating = \mQueue\Model\Status::Favorite;
                } elseif ($imdbRating >= $values['excellentMinimum']) {
                    $rating = \mQueue\Model\Status::Excellent;
                } elseif ($imdbRating >= $values['okMinimum']) {
                    $rating = \mQueue\Model\Status::Ok;
                } else {
                    $rating = \mQueue\Model\Status::Bad;
                }

                $movie->setStatus(\mQueue\Model\User::getCurrent(), $rating);
                $movies [] = $movie;
            }

            $count = count($movies);
            if ($count) {
                $this->_helper->FlashMessenger(_tr('Movies imported.'));
                $this->view->movies = $movies;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            } else {
                $this->_helper->FlashMessenger(['warning' => _tr('No movies found for import.')]);
            }
        }
    }
}


Push — master ( ca1336...ce2897 )

MovieController::importAction() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		class MovieController extends Zend_Controller_Action
		0 ignored issues – show Coding Style Compatibility introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4		{
5	3	public function init()
6		{
7		// Init the Context Switch Action helper
8	3	$contextSwitch = $this->_helper->contextSwitch();
9
10		// Add the new context
11	3	$contextSwitch->setContexts([
12	3	'csv' => ['suffix' => 'csv'],
13		'rss' => ['suffix' => 'rss'],
14		]);
15
16	3	$contextSwitch->addActionContext('index', 'csv')->addActionContext('index', 'rss')->initContext();
17	3	}
18
19	1	public function indexAction()
20		{
21		// Check there is at least one user, otherwise the whole page will crash
22	1	if (!\mQueue\Model\User::getCurrent() && !\mQueue\Model\UserMapper::getDbTable()->fetchRow()) {
23		throw new Exception('At least one user must exist to access this page');
24		}
25
26	1	$form = new \mQueue\Form\Filters();
27	1	$this->view->formFilter = $form;
		1 ignored issue – show Bug introduced 2016-03-14 20:04 UTC by Report Bug Copy Issue Report Accessing `formFilter` on the interface `Zend_View_Interface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
28
29		// Detect if at least one filter was submitted
30	1	$submitted = false;
31	1	foreach ($this->getRequest()->getParams() as $key => $filter) {
32	1	if (preg_match('/^filter\d+$/', $key)) {
33	1	$submitted = true;
34		}
35		}
36
37		// If was submitted and do not want to clear, try to validate values
38	1	if ($submitted && !$this->_getParam('clear', false)) {

PowerKiKi / mqueue

Push — master ( ca1336...ce2897 )

MovieController::importAction() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like