StatusController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	114
Duplicated Lines	0 %

Test Coverage

Coverage

31.03%

Importance

Changes	4
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	indexAction()	0	35	7
A	listAction()	0	25	5
A	init()	0	6	1
A	graphAction()	0	39	2

<?php

use mQueue\Model\Movie;
use mQueue\Model\MovieMapper;
use mQueue\Model\StatusMapper;
use mQueue\Model\User;
use mQueue\Model\UserMapper;

class StatusController extends Zend_Controller_Action
{
    public function init(): void
    {
        $contextSwitch = $this->_helper->getHelper('contextSwitch');
        $contextSwitch->addActionContext('list', 'json')

The method addActionContext() does not exist on Zend_Controller_Action_Helper_Abstract. It seems like you code against a sub-type of Zend_Controller_Action_Helper_Abstract such as Zend_Controller_Action_Helper_Cache or Zend_Controller_Action_Helper_ContextSwitch or Zend_Controller_Action_Helper_Redirector or Zend_Layout_Controller_Action_Helper_Layout.

            ->addActionContext('index', 'json')
            ->initContext();
    }

    public function indexAction(): void
    {
        $jsonCallback = $this->_request->getParam('jsoncallback');
        if ($jsonCallback) {
            $this->_helper->layout->setLayout('jsonp');

The method setLayout() does not exist on Zend_Controller_Action_Helper_Abstract. It seems like you code against a sub-type of Zend_Controller_Action_Helper_Abstract such as Zend_Controller_Action_Helper_Cache or Zend_Controller_Action_Helper_Redirector or Zend_Layout_Controller_Action_Helper_Layout.

            $this->view->jsonCallback = $jsonCallback;
        }

        $idMovie = Movie::extractId($this->_request->getParam('movie'));

        if ($idMovie == null) {

It seems like you are loosely comparing $idMovie of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            throw new Exception('no valid movie specified.');
        }

        // If new rating is specified and we are logged in, save it and create movie if needed
        $rating = $this->_request->getParam('rating');
        if (isset($rating) && User::getCurrent()) {
            $movie = MovieMapper::find($idMovie);

$idMovie of type string is incompatible with the type integer expected by parameter $id of mQueue\Model\MovieMapper::find().

            if ($movie == null) {
                $movie = MovieMapper::getDbTable()->createRow();
                $movie->setId($idMovie);
                $movie->save();
            }
            $status = $movie->setStatus(User::getCurrent(), $rating);
        } else {
            $status = StatusMapper::find($idMovie, User::getCurrent());

$idMovie of type string is incompatible with the type integer expected by parameter $idMovie of mQueue\Model\StatusMapper::find().

        }

        if (!$jsonCallback) {
            $this->view->status = $status;
        } else {
            $html = $this->view->statusLinks($status);
            $this->view->status = $html;
            $this->view->id = $status->getUniqueId();

The method getUniqueId() does not exist on Zend_Db_Table_Rowset_Abstract.

        }
    }

    public function listAction(): void
    {
        $jsonCallback = $this->_request->getParam('jsoncallback');
        if ($jsonCallback) {
            $this->_helper->layout->setLayout('jsonp');
            $this->view->jsonCallback = $jsonCallback;
        }

        $idMovies = [];
        foreach (explode(',', trim($this->_request->getParam('movies'), ',')) as $idMovie) {
            $idMovie = Movie::extractId($idMovie);
            if ($idMovie) {
                $idMovies[] = $idMovie;
            }
        }

        $statuses = StatusMapper::findAll($idMovies, User::getCurrent());

        $json = [];
        foreach ($statuses as $s) {
            $html = $this->view->statusLinks($s);
            $json[$s->getUniqueId()] = $html;
        }

        $this->view->status = $json;
    }

    public function graphAction(): void
    {
        $percent = $this->_request->getParam('percent');
        $user = UserMapper::find($this->getParam('user'));
        $data = StatusMapper::getGraph($user, $percent);
        $chart = [
            'chart' => [
                'zoomType' => 'x',
            ],
            'title' => [
                'text' => '',
            ],
            'xAxis' => [
                'type' => 'datetime',
            ],
            'yAxis' => [
                'title' => [
                    'text' => 'Movies',
                ],
                'min' => 0,
            ],
            'series' => $data,
        ];

        if ($percent) {
            $chart['chart']['type'] = 'area';
            $chart['yAxis']['title']['text'] = $chart['yAxis']['title']['text'] . ' [%]';
            $chart['plotOptions'] = [
                'area' => [
                    'stacking' => 'percent',
                    'marker' => [
                        'enabled' => false,
                    ],
                ],
            ];
        }

        echo Zend_Json::encode($chart, Zend_Json::TYPE_ARRAY);

Zend_Json::TYPE_ARRAY of type integer is incompatible with the type boolean expected by parameter $cycleCheck of Zend_Json::encode().

        die();

Using exit here is not recommended.

    }
}