ActivityController::init() - Code Metrics - Inspection of "Support any digit length and avoid duplicate probl..." - PowerKiKi/mqueue - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 1a6d63...dcbc0d )

by Adrien

created 2019-06-13 08:55 UTC

ActivityController::init() A

↳ Parent: ActivityController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
c	1
b	0
f	0
dl	0
loc	11
rs	10
ccs	5
cts	5
cp	1
cc	1
nc	1
nop	0
crap	1

<?php

class ActivityController extends Zend_Controller_Action
{
    public function init(): void
    {
        // Init the Context Switch Action helper
        $contextSwitch = $this->_helper->contextSwitch();

        // Add the new context
        $contextSwitch->setContexts([
            'rss' => ['suffix' => 'rss'],
        ]);

        $contextSwitch->addActionContext('index', 'rss')->initContext();
    }

    public function indexAction(): void
    {
        // By default we show overall activity
        $item = null;
        $this->view->title = $this->view->translate('Overall activity');

        // Try to show user's actitvity
        if ($this->getRequest()->getParam('user')) {
            $item = \mQueue\Model\UserMapper::find($this->getRequest()->getParam('user'));
            if ($item) {
                $this->view->title = $this->view->translate('Activity for %s', [$item->nickname]);

            }
        }

        // Try to show movie's actitvity
        if ($this->getRequest()->getParam('movie')) {
            $item = \mQueue\Model\MovieMapper::find($this->getRequest()->getParam('movie'));
            if ($item) {
                $this->view->title = $this->view->translate('Activity for %s', [$item->getTitle()]);
            }
        }

        $this->view->activity = $this->_helper->createPaginator(\mQueue\Model\StatusMapper::getActivityQuery($item));
    }
}


1		<?php
2
3		class ActivityController extends Zend_Controller_Action
4		{
5	3	public function init(): void
6		{
7		// Init the Context Switch Action helper
8	3	$contextSwitch = $this->_helper->contextSwitch();
9
10		// Add the new context
11	3	$contextSwitch->setContexts([
12	3	'rss' => ['suffix' => 'rss'],
13		]);
14
15	3	$contextSwitch->addActionContext('index', 'rss')->initContext();
16	3	}
17
18	3	public function indexAction(): void
19		{
20		// By default we show overall activity
21	3	$item = null;
22	3	$this->view->title = $this->view->translate('Overall activity');
23
24		// Try to show user's actitvity
25	3	if ($this->getRequest()->getParam('user')) {
26	1	$item = \mQueue\Model\UserMapper::find($this->getRequest()->getParam('user'));
27	1	if ($item) {
28	1	$this->view->title = $this->view->translate('Activity for %s', [$item->nickname]);
		0 ignored issues – show Bug Best Practice introduced 2019-06-13 09:00 UTC by Report Bug Copy Issue Report The property `nickname` does not exist on `mQueue\Model\User`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
29		}
30		}
31
32		// Try to show movie's actitvity
33	3	if ($this->getRequest()->getParam('movie')) {
34	1	$item = \mQueue\Model\MovieMapper::find($this->getRequest()->getParam('movie'));
35	1	if ($item) {
36	1	$this->view->title = $this->view->translate('Activity for %s', [$item->getTitle()]);
37		}
38		}
39
40	3	$this->view->activity = $this->_helper->createPaginator(\mQueue\Model\StatusMapper::getActivityQuery($item));
41	3	}
42		}
43

PowerKiKi / mqueue

Push — master ( 1a6d63...dcbc0d )

ActivityController::init() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like