UserController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	90
Duplicated Lines	15.56 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

71.43%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	viewAction()	0	13	3
A	newAction()	0	19	3
A	indexAction()	0	3	1
A	init()	0	2	1

<?php

class UserController extends Zend_Controller_Action
{
    public function init(): void
    {
        // Initialize action controller here
    }

    public function indexAction(): void
    {
        $this->view->users = \mQueue\Model\UserMapper::fetchAll();
    }

    public function newAction()
    {
        $request = $this->getRequest();
        $form = new \mQueue\Form\User();

        if ($this->getRequest()->isPost()) {

The method isPost() does not exist on Zend_Controller_Request_Abstract. It seems like you code against a sub-type of Zend_Controller_Request_Abstract such as Zend_Controller_Request_Http.

            if ($form->isValid($request->getPost())) {

The method getPost() does not exist on Zend_Controller_Request_Abstract. It seems like you code against a sub-type of Zend_Controller_Request_Abstract such as Zend_Controller_Request_Http.

                $values = $form->getValues();
                $user = \mQueue\Model\UserMapper::insertUser($values);

                \mQueue\Model\User::setCurrent($user);

                $this->_helper->FlashMessenger('Subscription complete.');

                return $this->_helper->redirector('index', 'movie');
            }
        }

        $this->view->form = $form;
    }

    public function loginAction()
    {
        $request = $this->getRequest();
        $form = new \mQueue\Form\Login();

        if ($this->getRequest()->isPost()) {
            if ($form->isValid($request->getPost())) {
                $values = $form->getValues();

                $user = \mQueue\Model\UserMapper::findEmailPassword($values['email'], $values['password']);
                if ($user) {
                    \mQueue\Model\User::setCurrent($user);

                    $this->_helper->FlashMessenger('Logged in.');

                    $referrer = $values['referrer'];

                    // If we have a valid referer to one page of ourselve (except login or logout), redirect to it
                    if (mb_strpos($referrer, $this->view->serverUrl() . $this->view->baseUrl()) === 0
                            && mb_strpos($referrer, $this->view->serverUrl() . $this->view->url(['controller' => 'user', 'action' => 'login'])) !== 0
                            && mb_strpos($referrer, $this->view->serverUrl() . $this->view->url(['controller' => 'user', 'action' => 'logout'])) !== 0) {
                        return $this->_redirect($values['referrer']);

The function Zend_Controller_Action::_redirect() has been deprecated: Deprecated as of Zend Framework 1.7. Use redirect() instead.

Are you sure the usage of $this->_redirect($values['referrer']) targeting Zend_Controller_Action::_redirect() seems to always return null.

                    }

                    return $this->_helper->redirector('index', 'movie');
                }
                $this->_helper->FlashMessenger(['error' => 'Login failed.']);
            }
        } else {
            $form->setDefaults([
                'referrer' => $this->getRequest()->getServer('HTTP_REFERER'),

The method getServer() does not exist on Zend_Controller_Request_Abstract. It seems like you code against a sub-type of Zend_Controller_Request_Abstract such as Zend_Controller_Request_Http.

            ]);
        }

        $this->view->form = $form;
    }

    public function logoutAction(): void
    {
        \mQueue\Model\User::setCurrent(null);
    }

    public function viewAction(): void
    {
        if ($this->getRequest()->getParam('id')) {
            $this->view->user = \mQueue\Model\UserMapper::find($this->getRequest()->getParam('id'));
        } else {
            $this->view->user = \mQueue\Model\User::getCurrent();
        }

        if (!$this->view->user) {

Accessing user on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

            throw new Exception($this->view->translate('User not found'));
        }

        $this->view->userActivity = $this->_helper->createPaginator(\mQueue\Model\StatusMapper::getActivityQuery($this->view->user));
    }
}