ActivityController::indexAction()

Complexity

Conditions	5
Paths	9

Size

Total Lines	23
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	5

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function indexAction(): void
    {
        // By default we show overall activity
        $item = null;
        $this->view->title = $this->view->translate('Overall activity');

        // Try to show user's activity
        if ($this->getRequest()->getParam('user')) {
            $item = UserMapper::find($this->getRequest()->getParam('user'));
            if ($item) {

$item is of type mQueue\Model\User, thus it always evaluated to true.

                $this->view->title = $this->view->translate('Activity for %s', [$item->nickname]);

The property nickname does not exist on mQueue\Model\User. Since you implemented __get, consider adding a @property annotation.

            }
        }

        // Try to show movie's activity
        if ($this->getRequest()->getParam('movie')) {
            $item = MovieMapper::find($this->getRequest()->getParam('movie'));
            if ($item) {

$item is of type mQueue\Model\Movie, thus it always evaluated to true.

                $this->view->title = $this->view->translate('Activity for %s', [$item->getTitle()]);
            }
        }

        $this->view->activity = $this->_helper->createPaginator(StatusMapper::getActivityQuery($item));
    }