ErrorController

Complexity

Total Complexity

10

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Test Coverage

Coverage

62.96%

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getLog()	0	9	2
B	errorAction()	0	41	8

<?php

class ErrorController extends Zend_Controller_Action
{
    public function errorAction(): void
    {
        $errors = $this->_getParam('error_handler');

        if (!$errors || !$errors instanceof ArrayObject) {
            $this->view->message = 'You have reached the error page';

            return;
        }

        switch ($errors->type) {

The property type does not seem to exist on ArrayObject.

            case Zend_Controller_Plugin_ErrorHandler::EXCEPTION_NO_ROUTE:
            case Zend_Controller_Plugin_ErrorHandler::EXCEPTION_NO_CONTROLLER:
            case Zend_Controller_Plugin_ErrorHandler::EXCEPTION_NO_ACTION:
                // 404 error -- controller or action not found
                $this->getResponse()->setHttpResponseCode(404);
                $priority = Zend_Log::NOTICE;
                $this->view->message = 'Page not found';

                break;
            default:
                // application error
                $this->getResponse()->setHttpResponseCode(500);
                $priority = Zend_Log::CRIT;
                $this->view->message = 'Application error';

                break;
        }

        // Log exception, if logger available
        if ($log = $this->getLog()) {
            $log->log($this->view->message, $priority, $errors->exception);

Accessing message on the interface Zend_View_Interface suggest that you code against a concrete implementation. How about adding an instanceof check?

The property exception does not seem to exist on ArrayObject.

            $log->log('Request Parameters', $priority, $errors->request->getParams());

The property request does not seem to exist on ArrayObject.

        }

        // conditionally display exceptions
        if ($this->getInvokeArg('displayExceptions') == true) {
            $this->view->exception = $errors->exception;
        }

        $this->view->request = $errors->request;
    }

    public function getLog()
    {
        $bootstrap = $this->getInvokeArg('bootstrap');
        if (!$bootstrap->hasResource('Log')) {
            return false;
        }
        $log = $bootstrap->getResource('Log');

        return $log;
    }
}