ChargeUsersTest::testChargeWithPaypal() - Code Metrics - Inspection of "Merge pull request #41 from Mahmoudz/strutures-upd..." - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c5f95...615c30 )

by Mahmoud

created 2016-07-18 05:32 UTC

ChargeUsersTest::testChargeWithPaypal() B

↳ Parent: ChargeUsersTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	25
Code Lines	12

Duplication

Lines	25
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	25
loc	25
rs	8.8571
cc	1
eloc	12
nc	1
nop	0

<?php

namespace App\Containers\Payments\Tests\Unit;

use App\Containers\Paypal\Actions\CreatePaypalAccountAction;
use App\Containers\Paypal\Services\ChargeWithPaypalService;
use App\Containers\Stripe\Actions\CreateStripeAccountAction;
use App\Containers\Stripe\Services\ChargeWithStripeService;
use App\Port\Tests\PHPUnit\Abstracts\TestCase;
use App\Containers\Payments\Services\PaymentsFactory;
use Illuminate\Support\Facades\App;

/**
 * Class ChargeUsersTest.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class ChargeUsersTest extends TestCase

{

    public function testChargeWithStripe()
    {
        // get the logged in user (create one if no one is logged in)
        $user = $this->registerAndLoginTestingUser();

        // create stripe account for this user
        $createStripeAccountAction = App::make(CreateStripeAccountAction::class);
        $stripeAccount = $createStripeAccountAction->run($user, 'cus_8mBD5S1SoyD4zL', 'card_18Uck6KFvMcBUkvQorbBkYhR', 'credit', '4242', 'WsNM4K8puHbdS2VP');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $payId = 'ch_z8WDARKFvzcBUkvQzrbBvfhz';

        // mock the ChargeWithStripeService external API call
        $this->mock(ChargeWithStripeService::class)->shouldReceive('charge')->andReturn([
            'payment_method' => 'stripe',
            'description'    => $payId
        ]);

        $paymentsFactory = new PaymentsFactory();
        $result = $paymentsFactory->charge($user, 1000, 'USD');

        $this->assertEquals($result['payment_method'], 'stripe');
        $this->assertEquals($result['description'], $payId);
    }

    public function testChargeWithPaypal()
    {
        // get the logged in user (create one if no one is logged in)
        $user = $this->registerAndLoginTestingUser();

        // create stripe account for this user
        $createPaypalAccountAction = App::make(CreatePaypalAccountAction::class);
        $paypalAccount = $createPaypalAccountAction->run($user, '8mBD5S1SoyD4zL');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $payId = 'PAY-04797768K5905283VK6DGEMZ';

        // mock the ChargeWithPaypalService external API call
        $this->mock(ChargeWithPaypalService::class)->shouldReceive('charge')->andReturn([
            'payment_method' => 'paypal',
            'description'    => $payId
        ]);

        // TODO: comment out the pocking part above and test the real API call

        $paymentsFactory = new PaymentsFactory();
        $result = $paymentsFactory->charge($user, 1000, 'USD');

        $this->assertEquals($result['payment_method'], 'paypal');
        $this->assertEquals($result['description'], $payId);
    }

}


1		<?php
2
3		namespace App\Containers\Payments\Tests\Unit;
4
5		use App\Containers\Paypal\Actions\CreatePaypalAccountAction;
6		use App\Containers\Paypal\Services\ChargeWithPaypalService;
7		use App\Containers\Stripe\Actions\CreateStripeAccountAction;
8		use App\Containers\Stripe\Services\ChargeWithStripeService;
9		use App\Port\Tests\PHPUnit\Abstracts\TestCase;
10		use App\Containers\Payments\Services\PaymentsFactory;
11		use Illuminate\Support\Facades\App;
12
13		/**
14		* Class ChargeUsersTest.
15		*
16		* @author Mahmoud Zalt <[email protected]>
17		*/
18	View Code Duplication	class ChargeUsersTest extends TestCase
		0 ignored issues – show Duplication introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20
21		public function testChargeWithStripe()
22		{
23		// get the logged in user (create one if no one is logged in)
24		$user = $this->registerAndLoginTestingUser();
25
26		// create stripe account for this user
27		$createStripeAccountAction = App::make(CreateStripeAccountAction::class);
28		$stripeAccount = $createStripeAccountAction->run($user, 'cus_8mBD5S1SoyD4zL', 'card_18Uck6KFvMcBUkvQorbBkYhR', 'credit', '4242', 'WsNM4K8puHbdS2VP');
		0 ignored issues – show Unused Code introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report `$stripeAccount` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
29
30		$payId = 'ch_z8WDARKFvzcBUkvQzrbBvfhz';
31
32		// mock the ChargeWithStripeService external API call
33		$this->mock(ChargeWithStripeService::class)->shouldReceive('charge')->andReturn([
34		'payment_method' => 'stripe',
35		'description' => $payId
36		]);
37
38		$paymentsFactory = new PaymentsFactory();
39		$result = $paymentsFactory->charge($user, 1000, 'USD');
40
41		$this->assertEquals($result['payment_method'], 'stripe');
42		$this->assertEquals($result['description'], $payId);
43		}
44
45		public function testChargeWithPaypal()
46		{
47		// get the logged in user (create one if no one is logged in)
48		$user = $this->registerAndLoginTestingUser();
49
50		// create stripe account for this user
51		$createPaypalAccountAction = App::make(CreatePaypalAccountAction::class);
52		$paypalAccount = $createPaypalAccountAction->run($user, '8mBD5S1SoyD4zL');
		0 ignored issues – show Unused Code introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report `$paypalAccount` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
53
54		$payId = 'PAY-04797768K5905283VK6DGEMZ';
55
56		// mock the ChargeWithPaypalService external API call
57		$this->mock(ChargeWithPaypalService::class)->shouldReceive('charge')->andReturn([
58		'payment_method' => 'paypal',
59		'description' => $payId
60		]);
61
62		// TODO: comment out the pocking part above and test the real API call
63
64		$paymentsFactory = new PaymentsFactory();
65		$result = $paymentsFactory->charge($user, 1000, 'USD');
66
67		$this->assertEquals($result['payment_method'], 'paypal');
68		$this->assertEquals($result['description'], $payId);
69		}
70
71		}
72

Porto-SAP / Hello-API

Push — master ( 4c5f95...615c30 )

ChargeUsersTest::testChargeWithPaypal() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like