App\Containers\User\UI\API\Tests\Functional\UpdateUserTest

Complexity

Total Complexity

2

Size/Duplication

Total Lines	76
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testUpdateExistingUser_()	0	26	1
A	testUpdateExistingUserWithEmptyValues()	19	19	1

<?php

namespace App\Containers\User\UI\API\Tests\Functional;

use App\Port\Tests\PHPUnit\Abstracts\TestCase;

/**
 * Class UpdateUserTest.
 *
 * @author Mahmoud Zalt <mahmoud@zalt.me>
 */
class UpdateUserTest extends TestCase
{

    private $endpoint = '/users';

    public function testUpdateExistingUser_()
    {
        $user = $this->getLoggedInTestingUser();

        $data = [
            'name'     => 'Updated Name',
            'password' => 'updated#Password',
        ];

        $endpoint = $this->endpoint . '/' . $user->id;

        // send the HTTP request
        $response = $this->apiCall($endpoint, 'put', $data);

        // assert response status is correct
        $this->assertEquals($response->getStatusCode(), '200');

        // assert returned user is the updated one
        $this->assertResponseContainKeyValue([
            'email' => $user->email,
            'name'  => $data['name'],
        ], $response);

        // assert data was updated in the database
        $this->seeInDatabase('users', ['name' => $data['name']]);
    }

    public function testUpdateExistingUserWithEmptyValues()

This method seems to be duplicated in your project.

    {
        $user = $this->getLoggedInTestingUser();

        $data = []; // empty data

        $endpoint = $this->endpoint . '/' . $user->id;

        // send the HTTP request
        $response = $this->apiCall($endpoint, 'put', $data);

        // assert response status is correct
        $this->assertEquals($response->getStatusCode(), '417');

        // assert message is correct
        $this->assertResponseContainKeyValue([
            'message' => 'All inputs are empty.',
        ], $response);
    }

    // TODO: after upgrading to Laravel 5.2 this function started returning 500 instead of 403
    // it could be due to something in `app/Port/Exception/Handler/ExceptionsHandler.php` and the don't report thingy
    // same problem as testDeleteDifferentUser

//    public function testUpdateDifferentUser_()

48% of this comment could be valid code. Did you maybe forget this after debugging?

//    {
//        $data = [
//            'name'     => 'Updated Name',
//            'password' => 'updated#Password',
//        ];
//
//        $endpoint = $this->endpoint . '/' . 100; // amy ID
//
//        // send the HTTP request
//        $response = $this->apiCall($endpoint, 'put', $data);
//
//        // assert response status is correct
//        $this->assertEquals($response->getStatusCode(), '403');
//
//        // assert the message means (not allowed to proceed with the request)
//        $this->assertEquals($response->getContent(), 'Forbidden');
//    }

}