Controller - Code Metrics - Inspection of "Merge pull request #41 from Mahmoudz/strutures-upd..." - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4c5f95...615c30 )

by Mahmoud

created 2016-07-18 05:32 UTC

Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	1
c	1
b	0
f	0
lcom	0
cbo	3
dl	0
loc	27
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	confirmUserEmail()	0	15	1

<?php

namespace App\Containers\Email\UI\WEB\Controllers;

use App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest;
use App\Containers\Email\Actions\ValidateConfirmationCodeAction;
use App\Containers\User\Actions\FindUserByIdAction;
use App\Port\Controller\Abstracts\PortWebController;
use Illuminate\Support\Facades\Config;

/**
 * Class Controller.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class Controller extends PortWebController
{

    /**
     * @param \App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest       $confirmUserEmailRequest
     * @param \App\Containers\User\Actions\FindUserByIdAction              $findUserByIdAction
     * @param \App\Containers\Email\Actions\ValidateConfirmationCodeAction $validateConfirmationCodeAction
     *
     * @return  \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     */
    public function confirmUserEmail(
        ConfirmUserEmailRequest $confirmUserEmailRequest,
        FindUserByIdAction $findUserByIdAction,
        ValidateConfirmationCodeAction $validateConfirmationCodeAction
    ) {

        // find user by ID
        $user = $findUserByIdAction->run($confirmUserEmailRequest->id);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // validate the confirmation code and update user status is code is valid
        $validateConfirmationCodeAction->run($user, $confirmUserEmailRequest->code);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // redirect to the app URL
        return redirect(Config::get('app.url'));
    }

}


1			<?php
2
3			namespace App\Containers\Email\UI\WEB\Controllers;
4
5			use App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest;
6			use App\Containers\Email\Actions\ValidateConfirmationCodeAction;
7			use App\Containers\User\Actions\FindUserByIdAction;
8			use App\Port\Controller\Abstracts\PortWebController;
9			use Illuminate\Support\Facades\Config;
10
11			/**
12			* Class Controller.
13			*
14			* @author Mahmoud Zalt <[email protected]>
15			*/
16			class Controller extends PortWebController
17			{
18
19			/**
20			* @param \App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest $confirmUserEmailRequest
21			* @param \App\Containers\User\Actions\FindUserByIdAction $findUserByIdAction
22			* @param \App\Containers\Email\Actions\ValidateConfirmationCodeAction $validateConfirmationCodeAction
23			*
24			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Routing\Redirector
25			*/
26			public function confirmUserEmail(
27			ConfirmUserEmailRequest $confirmUserEmailRequest,
28			FindUserByIdAction $findUserByIdAction,
29			ValidateConfirmationCodeAction $validateConfirmationCodeAction
30			) {
31
32			// find user by ID
33			$user = $findUserByIdAction->run($confirmUserEmailRequest->id);
			0 ignored issues – show Documentation introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Containers\Em...onfirmUserEmailRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34
35			// validate the confirmation code and update user status is code is valid
36			$validateConfirmationCodeAction->run($user, $confirmUserEmailRequest->code);
			0 ignored issues – show Documentation introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report The property `code` does not exist on `object<App\Containers\Em...onfirmUserEmailRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37
38			// redirect to the app URL
39			return redirect(Config::get('app.url'));
40			}
41
42			}
43

Porto-SAP / Hello-API

Push — master ( 4c5f95...615c30 )

Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like