App\Port\Command\Commands\DownloadContainersCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
B	handle()	0	35	4

<?php

namespace App\Port\Command\Commands;

use App\Port\Console\Abstracts\ConsoleCommand;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

/**
 * Class DownloadContainersCommand
 *
 * @author  Mahmoud Zalt  <mahmoud@zalt.me>
 */
class DownloadContainersCommand extends ConsoleCommand
{

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = "container:download {repository-name*}"; // {--skip-update=false}

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = "select existing container to download";

    /**
     * Create a new command instance.
     *
     * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $ContainersPath = "app/Containers";

        foreach ($this->argument("repository-name") as $repoName) {

The expression $this->argument('repository-name') of type string|array is not guaranteed to be traversable. How about adding an additional type check?

            $repoName = ucfirst(strtolower($repoName));

            // TODO: find a way to validate the repo!
            $process = new Process("git clone git@github.com:Porto-SAP/" . $repoName . ".git " . $ContainersPath . "/" . $repoName);
            $process->run();

            if (!$process->isSuccessful()) {
                throw new ProcessFailedException($process);
            }

            echo "Downloading " . $repoName . " completed successfully.\n";
        }

        // TODO: add skip update option

//        if (!$this->option('skip-update')) {

72% of this comment could be valid code. Did you maybe forget this after debugging?

            echo "Running 'Composer Update'..\n";
            $process = new Process("composer update");
            $process->run();

            if (!$process->isSuccessful()) {
                throw new ProcessFailedException($process);
            }

            echo $process->getOutput();
//        }

        echo "Congratulation :)\n";
    }
}