App\Containers\Authorization\Traits\AuthorizationTrait

Complexity

Total Complexity

12

Size/Duplication

Total Lines	91
Duplicated Lines	32.97 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getUser()	0	4	1
A	hasAdminRole()	0	4	1
A	hasClientRole()	0	4	1
A	hasAccess()	0	13	3
A	hasAnyPermissionAccess()	15	15	3
A	hasAnyRoleAccess()	15	15	3

<?php

namespace App\Containers\Authorization\Traits;

use Illuminate\Support\Facades\Auth;

/**
 * Class AuthorizationTrait
 *
 * @author  Mahmoud Zalt  <mahmoud@zalt.me>
 */
trait AuthorizationTrait
{

    /**
     * @return  \App\Containers\User\Models\User|null
     */
    public function getUser()
    {
        return Auth::user();
    }

    /**
     * @return  mixed
     */
    public function hasAdminRole()
    {
        return $this->hasRole('admin');

It seems like hasRole() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * @return  mixed
     */
    public function hasClientRole()
    {
        return $this->hasRole('client');

It seems like hasRole() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * This function will be called from the Requests (authorize) to check if a user
     * has permission to perform an action.
     * User can set multiple permissions (separated with "|") and if the user has
     * any of the permissions, he will be authorize to proceed with this action.
     *
     * @return  bool
     */
    public function hasAccess(User $user = null)
    {
        // if not in parameters, take from the request object {$this}
        $user = $user ? : $this->user();

It seems like user() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $hasAccess = array_merge(
            $this->hasAnyPermissionAccess($user),
            $this->hasAnyRoleAccess($user)
        );

        // allow access if user has access to any of the defined roles or permissions.
        return empty($hasAccess) ? true : in_array(true, $hasAccess);
    }

    /**
     * @param $user
     *
     * @return  array
     */
    private function hasAnyPermissionAccess($user)

This method seems to be duplicated in your project.

    {
        if (!array_key_exists('permissions', $this->access) || !$this->access['permissions']) {

The property access does not exist. Did you maybe forget to declare it?

            return [];
        }

        $permissions = explode('|', $this->access['permissions']);

        $hasAccess = array_map(function ($permission) use ($user) {
            // Note: internal return
            return $user->hasPermissionTo($permission);
        }, $permissions);

        return $hasAccess;
    }

    /**
     * @param $user
     *
     * @return  array
     */
    private function hasAnyRoleAccess($user)

This method seems to be duplicated in your project.

    {
        if (!array_key_exists('roles', $this->access) || !$this->access['roles']) {
            return [];
        }

        $roles = explode('|', $this->access['roles']);

        $hasAccess = array_map(function ($role) use ($user) {
            // Note: internal return
            return $user->hasRole($role);
        }, $roles);

        return $hasAccess;
    }
}