ProvidersLoaderTrait::loadOnlyMainProvidersFromContainers() - Code Metrics - Inspection of "more refactoring on the autoloaders" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7eefd3...6db0a4 )

by Mahmoud

created 2017-02-20 18:55 UTC

loadOnlyMainProvidersFromContainers() A

↳ Parent: ProvidersLoaderTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	1

<?php

namespace App\Ship\Engine\Loaders;

use App;
use App\Ship\Engine\Butlers\Facades\ShipButler;
use File;

/**
 * Class ProvidersLoaderTrait.
 *
 * @author  Mahmoud Zalt <[email protected]>
 */
trait ProvidersLoaderTrait
{

    /**
     * Loads only the Main Service Providers from the Containers.
     * All the Service Providers (registered inside the main), will be
     * loaded from the `boot()` function on the parent of the Main
     * Service Providers.
     *
     * @param $containerName
     */
    public function loadOnlyMainProvidersFromContainers($containerName)
    {
        $containerProvidersDirectory = base_path('app/Containers/' . $containerName . '/Providers');

        $this->loadProviders($containerProvidersDirectory);
    }

    /**
     * @param $directory
     */
    private function loadProviders($directory)
    {
        $mainServiceProviderNameStartWith = 'Main';

        if (File::isDirectory($directory)) {

            $files = File::allFiles($directory);

            foreach ($files as $file) {


                if (File::isFile($file)) {

                    // Check if this is the Main Service Provider
                    if (ShipButler::stringStartsWith($file->getFilename(), $mainServiceProviderNameStartWith)) {

                        $serviceProviderClass = ShipButler::getClassFullNameFromFile($file->getPathname());

                        $this->loadProvider($serviceProviderClass);
                    }
                }
            }
        }
    }

    /**
     * @param $providerFullName
     */
    private function loadProvider($providerFullName)
    {
        App::register($providerFullName);
    }

    /**
     * @void
     */
    public function loadServiceProviders()
    {
        foreach ($this->serviceProviders as $provider) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->loadProvider($provider);
        }
    }

}


1		<?php
2
3		namespace App\Ship\Engine\Loaders;
4
5		use App;
6		use App\Ship\Engine\Butlers\Facades\ShipButler;
7		use File;
8
9		/**
10		* Class ProvidersLoaderTrait.
11		*
12		* @author Mahmoud Zalt <[email protected]>
13		*/
14		trait ProvidersLoaderTrait
15		{
16
17		/**
18		* Loads only the Main Service Providers from the Containers.
19		* All the Service Providers (registered inside the main), will be
20		* loaded from the `boot()` function on the parent of the Main
21		* Service Providers.
22		*
23		* @param $containerName
24		*/
25		public function loadOnlyMainProvidersFromContainers($containerName)
26		{
27		$containerProvidersDirectory = base_path('app/Containers/' . $containerName . '/Providers');
28
29		$this->loadProviders($containerProvidersDirectory);
30		}
31
32		/**
33		* @param $directory
34		*/
35		private function loadProviders($directory)
36		{
37		$mainServiceProviderNameStartWith = 'Main';
38
39		if (File::isDirectory($directory)) {
40
41		$files = File::allFiles($directory);
42
43	View Code Duplication	foreach ($files as $file) {
		0 ignored issues – show Duplication introduced 2017-02-18 23:21 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44
45		if (File::isFile($file)) {
46
47		// Check if this is the Main Service Provider
48		if (ShipButler::stringStartsWith($file->getFilename(), $mainServiceProviderNameStartWith)) {
49
50		$serviceProviderClass = ShipButler::getClassFullNameFromFile($file->getPathname());
51
52		$this->loadProvider($serviceProviderClass);
53		}
54		}
55		}
56		}
57		}
58
59		/**
60		* @param $providerFullName
61		*/
62		private function loadProvider($providerFullName)
63		{
64		App::register($providerFullName);
65		}
66
67		/**
68		* @void
69		*/
70		public function loadServiceProviders()
71		{
72		foreach ($this->serviceProviders as $provider) {
		0 ignored issues – show Bug introduced 2016-12-01 20:29 UTC by Report Bug Copy Issue Report The property `serviceProviders` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
73		$this->loadProvider($provider);
74		}
75		}
76
77		}
78

Porto-SAP / Hello-API

Push — master ( 7eefd3...6db0a4 )

loadOnlyMainProvidersFromContainers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like