Completed
Push — master ( a8f538...8e198c )
by Mahmoud
07:38
created
app/Containers/Authorization/Tasks/AssignRoleTask.php 2 patches
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public function run($user, $roles)
47 47
     {
48
-        if(!$user instanceof User){
48
+        if (!$user instanceof User) {
49 49
             $user = $this->findUserByIdTask->run($user);
50 50
         }
51 51
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
                 $this->assignRole($user, $role);
55 55
             }
56 56
 
57
-        }else{
57
+        } else {
58 58
             $this->assignRole($user, $roles);
59 59
         }
60 60
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
                 $this->assignRole($user, $role);
55 55
             }
56 56
 
57
-        }else{
57
+        } else{
58 58
             $this->assignRole($user, $roles);
59 59
         }
60 60
 
Please login to merge, or discard this patch.
app/Containers/Authorization/Tasks/AttachPermissionsToRoleTask.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,13 +42,13 @@
 block discarded – undo
42 42
     {
43 43
         $role = $this->getRoleAction->run($roleName);
44 44
 
45
-        if(is_array($permissionNames)){
45
+        if (is_array($permissionNames)) {
46 46
 
47
-            foreach ($permissionNames as $permissionName){
47
+            foreach ($permissionNames as $permissionName) {
48 48
                 $role->givePermissionTo($permissionName);
49 49
             }
50 50
 
51
-        }else{
51
+        } else {
52 52
             $role->givePermissionTo($permissionNames);
53 53
         }
54 54
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
                 $role->givePermissionTo($permissionName);
49 49
             }
50 50
 
51
-        }else{
51
+        } else{
52 52
             $role->givePermissionTo($permissionNames);
53 53
         }
54 54
 
Please login to merge, or discard this patch.
app/Containers/Authentication/Actions/WebAdminLoginAction.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     {
48 48
         $user = $this->webLoginTask->run($email, $password, $remember);
49 49
 
50
-        if($user){
50
+        if ($user) {
51 51
             $this->isUserAdminTask->run($user);
52 52
         }
53 53
 
Please login to merge, or discard this patch.
app/Containers/Authorization/UI/API/Tests/Functional/ListRolesTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace App\Containers\Authorization\UI\API\Tests\Functional;
4 4
 
5
-use App\Containers\Authorization\Models\User;
6 5
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
7 6
 
8 7
 /**
Please login to merge, or discard this patch.
app/Containers/Stripe/Tasks/CreateStripeAccountObjectTask.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use App\Containers\Stripe\Models\StripeAccount;
7 7
 use App\Containers\User\Models\User;
8 8
 use App\Port\Task\Abstracts\Task;
9
-use Auth;
10 9
 
11 10
 /**
12 11
  * Class CreateStripeAccountObjectTask.
Please login to merge, or discard this patch.
app/Port/Provider/Loaders/ProvidersLoaderTrait.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use App;
6 6
 use App\Port\Foundation\Portals\Facade\PortButler;
7
-use DB;
8 7
 use File;
9
-use Log;
10 8
 
11 9
 /**
12 10
  * Class ProvidersLoaderTrait.
Please login to merge, or discard this patch.
app/Port/View/Loaders/ViewsLoaderTrait.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -44,6 +44,9 @@
 block discarded – undo
44 44
 
45 45
     }
46 46
 
47
+    /**
48
+     * @param string $directory
49
+     */
47 50
     private function loadViews($directory)
48 51
     {
49 52
         View::addLocation($directory);
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,10 +4,8 @@
 block discarded – undo
4 4
 
5 5
 use App;
6 6
 use App\Port\Foundation\Portals\Facade\PortButler;
7
-use DB;
8 7
 use File;
9 8
 use Illuminate\Support\Facades\View;
10
-use Log;
11 9
 
12 10
 /**
13 11
  * Class ViewsLoaderTrait.
Please login to merge, or discard this patch.
app/Containers/Authentication/UI/WEB/Routes/main.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 // TODO: these needs to be separated into multiple routes files
3
-$router->group(['domain' => 'admin.'. env('APP_URL')], function ($router) {
3
+$router->group(['domain' => 'admin.' . env('APP_URL')], function($router) {
4 4
 
5 5
     $router->get('/', [
6 6
         'uses' => 'Controller@showLoginPage',
Please login to merge, or discard this patch.
app/Containers/Socialauth/Actions/SocialLoginAction.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -102,10 +102,10 @@
 block discarded – undo
102 102
 
103 103
         // checking if some data are available in the response
104 104
         // (these lines are written to make this function compatible with multiple providers)
105
-        $tokenSecret = isset($socialUserProfile->tokenSecret) ? : null;
106
-        $expiresIn = isset($socialUserProfile->expiresIn) ? : null;
107
-        $refreshToken = isset($socialUserProfile->refreshToken) ? : null;
108
-        $avatar_original = isset($socialUserProfile->avatar_original) ? : null;
105
+        $tokenSecret = isset($socialUserProfile->tokenSecret) ?: null;
106
+        $expiresIn = isset($socialUserProfile->expiresIn) ?: null;
107
+        $refreshToken = isset($socialUserProfile->refreshToken) ?: null;
108
+        $avatar_original = isset($socialUserProfile->avatar_original) ?: null;
109 109
 
110 110
         // check if the social ID exist on any of our users, and get that user in case it was found
111 111
         $socialUser = $this->findSocialUserTask->run($provider, $socialUserProfile->id);
Please login to merge, or discard this patch.