Porto-SAP / Hello-API

app/Port/Loader/Loaders/ConsolesLoaderTrait.php

Doc Comments +1 added lines

@@ -39,6 +39,7 @@
 
     /**
      * @param $consoleClass
+     * @param string $directory
      */
     private function loadTheConsoles($directory)
     {

app/Port/Test/PHPUnit/Abstracts/TestCase.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         $this->baseUrl = env('API_FULL_URL'); // this reads the value from `phpunit.xml` during testing
 
         // override the default subDomain of the base URL when subDomain property is declared inside a test
-        if(property_exists($this, 'subDomain')){
+        if (property_exists($this, 'subDomain')) {
             $this->overrideSubDomain($this->subDomain);
         }
 

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Faker\Generator;
 use Illuminate\Contracts\Console\Kernel as LaravelKernel;
 //use Illuminate\Foundation\Testing\TestCase as LaravelTestCase;
-use Illuminate\Support\Facades\DB;
 use Laravel\BrowserKitTesting\TestCase as LaravelFivePointThreeTestCaseCompatibilityPackage;
 use App\Port\Test\PHPUnit\Traits\TestingTrait;
 

app/Port/Loader/Loaders/SeederLoaderTrait.php

Doc Comments +4 added lines, -4 removed lines

@@ -70,8 +70,8 @@ 
     }
 
     /**
-     * @param array $directories
-     * @param       $seedersClasses
+     * @param string[] $directories
+     * @param       Collection $seedersClasses
      *
      * @return  mixed
      */
@@ -103,7 +103,7 @@ 
     /**
      * @param $seedersClasses
      *
-     * @return  \Illuminate\Support\Collection|static
+     * @return  Collection|null
      */
     private function sortSeeders($seedersClasses)
     {
@@ -140,7 +140,7 @@ 
     }
 
     /**
-     * @param $seedersClasses
+     * @param Collection|null $seedersClasses
      */
     private function loadSeeders($seedersClasses)
     {

Spacing +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
             }
 
             // sort the classes that needed to be ordered
-            $orderedSeederClasses = $orderedSeederClasses->sortBy(function ($seederFullClassName) {
+            $orderedSeederClasses = $orderedSeederClasses->sortBy(function($seederFullClassName) {
                 // get the order number form the end of each class name
                 $orderNumber = substr($seederFullClassName, strpos($seederFullClassName, "_") + 1);
 

app/Containers/User/UI/API/Routes/CreateAdmin.v1.private.php

Indentation +1 added lines, -1 removed lines

@@ -44,6 +44,6 @@
 $router->post('admins/create', [
     'uses'  => 'Controller@createAdmin',
     'middleware' => [
-      'api.auth',
+        'api.auth',
     ],
 ]);

app/Containers/Authorization/Traits/AuthorizationTrait.php

Spacing +3 added lines, -3 removed lines

@@ -47,7 +47,7 @@ 
     public function hasAccess(User $user = null)
     {
         // if not in parameters, take from the request object {$this}
-        $user = $user ? : $this->user();
+        $user = $user ?: $this->user();
 
         $hasAccess = array_merge(
             $this->hasAnyPermissionAccess($user),
@@ -71,7 +71,7 @@ 
 
         $permissions = explode('|', $this->access['permissions']);
 
-        $hasAccess = array_map(function ($permission) use ($user) {
+        $hasAccess = array_map(function($permission) use ($user) {
             // Note: internal return
             return $user->hasPermissionTo($permission);
         }, $permissions);
@@ -92,7 +92,7 @@ 
 
         $roles = explode('|', $this->access['roles']);
 
-        $hasAccess = array_map(function ($role) use ($user) {
+        $hasAccess = array_map(function($role) use ($user) {
             // Note: internal return
             return $user->hasRole($role);
         }, $roles);

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
 {
 
     /**
-     * @return  \App\Containers\User\Models\User|null
+     * @return  \Illuminate\Contracts\Auth\Authenticatable|null
      */
     public function getUser()
     {

app/Port/Test/PHPUnit/Traits/TestingTrait.php

Spacing +3 added lines, -3 removed lines

@@ -168,7 +168,7 @@ 
     {
 
         // if no user detail provided, use the default details.
-        $userDetails = $userDetails ? : [
+        $userDetails = $userDetails ?: [
             'name'     => 'Testing User',
             'email'    => $this->faker->email,
             'password' => 'testing-pass',
@@ -182,7 +182,7 @@ 
         ]);
 
         // assign roles and permissions
-        $user = $this->setupTestingUserAccess($user, $access ? : (isset($this->access) ? $this->access : null));
+        $user = $this->setupTestingUserAccess($user, $access ?: (isset($this->access) ? $this->access : null));
 
         // log the user in
         $user = App::make(ApiLoginThisUserObjectTask::class)->run($user);
@@ -379,7 +379,7 @@ 
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

Doc Comments +2 added lines, -2 removed lines

@@ -224,7 +224,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)
@@ -352,7 +352,7 @@ 
      *
      * Example: you give it ('users/{id}/stores', 100) it returns 'users/100/stores'
      *
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param        $id
      * @param bool   $skipEncoding
      * @param string $replace

app/Containers/Debugger/Traits/DebuggerTrait.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
     public function runQueryDebugger($log = true, $terminal = false)
     {
         if (Config::get('hello.query_debugger')) {
-            DB::listen(function ($event) use ($terminal, $log) {
+            DB::listen(function($event) use ($terminal, $log) {
                 $fullQuery = vsprintf(str_replace(['%', '?'], ['%%', '%s'], $event->sql), $event->bindings);
 
                 $text = $event->connectionName . ' (' . $event->time . '): ' . $fullQuery;

app/Containers/Authorization/UI/API/Controllers/Controller.php

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 use App\Containers\Authorization\UI\API\Requests\RevokeUserFromRoleRequest;
 use App\Containers\Authorization\UI\API\Transformers\PermissionTransformer;
 use App\Containers\Authorization\UI\API\Transformers\RoleTransformer;
-use App\Containers\User\Models\User;
 use App\Containers\User\UI\API\Transformers\UserTransformer;
 use App\Port\Controller\Abstracts\PortApiController;
 

app/Containers/Authorization/Data/Factories/RoleFactory.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 // User
 use App\Containers\Authorization\Models\Role;
 
-$factory->define(Role::class, function (Faker\Generator $faker) {
+$factory->define(Role::class, function(Faker\Generator $faker) {
 
     return [
         'name' => $faker->slug,