Completed
Push — master ( 9e2978...438a01 )
by Mahmoud
03:41
created
app/Ship/Features/Payment/Proxies/PaymentsProxy.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
     }
38 38
 
39 39
     /**
40
-     * @param $object
40
+     * @param ChargeableInterface $object
41 41
      *
42 42
      * @return  null
43 43
      */
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     }
48 48
 
49 49
     /**
50
-     * @param $object
50
+     * @param ChargeableInterface $object
51 51
      *
52 52
      * @return  null
53 53
      */
Please login to merge, or discard this patch.
app/Ship/Features/Tests/PhpUnit/TestsAuthHelperTrait.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -154,7 +154,7 @@
 block discarded – undo
154 154
     }
155 155
 
156 156
     /**
157
-     * @param $user
157
+     * @param User $user
158 158
      * @param $access
159 159
      *
160 160
      * @return  mixed
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -5,8 +5,6 @@
 block discarded – undo
5 5
 use App;
6 6
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
7 7
 use App\Containers\User\Models\User;
8
-use Artisan;
9
-use Dingo\Api\Http\Response as DingoAPIResponse;
10 8
 use Illuminate\Support\Facades\Hash;
11 9
 
12 10
 /**
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      */
79 79
     private function findOrCreateTestingUser($userDetails, $access)
80 80
     {
81
-        return $this->testingUser ? : $this->createTestingUser($userDetails, $access);
81
+        return $this->testingUser ?: $this->createTestingUser($userDetails, $access);
82 82
     }
83 83
 
84 84
     /**
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         ];
127 127
 
128 128
         // if no user detail provided, use the default details, to find the password or generate one before encoding it
129
-        return $this->prepareUserPassword($userDetails ? : $defaultUserDetails);;
129
+        return $this->prepareUserPassword($userDetails ?: $defaultUserDetails); ;
130 130
     }
131 131
 
132 132
     /**
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      */
162 162
     private function setupTestingUserAccess($user, $access)
163 163
     {
164
-        $access = $access ? : $this->getAccess();
164
+        $access = $access ?: $this->getAccess();
165 165
 
166 166
         $user = $this->setupTestingUserPermissions($user, $access);
167 167
         $user = $this->setupTestingUserRoles($user, $access);
Please login to merge, or discard this patch.
app/Ship/Features/Tests/PhpUnit/TestsRequestHelperTrait.php 1 patch
Doc Comments   +3 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,9 +63,7 @@  discard block
 block discarded – undo
63 63
 
64 64
     /**
65 65
      * @param        $this ->endpointUrl
66
-     * @param string $this ->endpointVerb
67 66
      * @param array  $data
68
-     * @param bool   $protected
69 67
      * @param array  $headers
70 68
      *
71 69
      * @return  mixed
@@ -91,7 +89,7 @@  discard block
 block discarded – undo
91 89
      * @param bool   $skipEncoding
92 90
      * @param string $replace
93 91
      *
94
-     * @return  mixed
92
+     * @return  TestsRequestHelperTrait
95 93
      */
96 94
     public function injectId($id, $skipEncoding = false, $replace = '{id}')
97 95
     {
@@ -108,7 +106,7 @@  discard block
 block discarded – undo
108 106
      *
109 107
      * to be used as follow: $this->endpoint('verb@url')->makeCall($data);
110 108
      *
111
-     * @param $endpoint
109
+     * @param string $endpoint
112 110
      *
113 111
      * @return  $this
114 112
      */
@@ -282,7 +280,7 @@  discard block
 block discarded – undo
282 280
     }
283 281
 
284 282
     /**
285
-     * @param $separator
283
+     * @param string $separator
286 284
      */
287 285
     private function validateEndpointFormat($separator)
288 286
     {
Please login to merge, or discard this patch.
app/Ship/Features/Tests/PhpUnit/TestsResponseHelperTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     }
62 62
 
63 63
     /**
64
-     * @param $keys
64
+     * @param string[] $keys
65 65
      * @param $httpResponse
66 66
      */
67 67
     public function assertResponseContainKeys($keys, $httpResponse)
Please login to merge, or discard this patch.
app/Containers/User/Data/Factories/UserFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@
 block discarded – undo
2 2
 
3 3
 use Illuminate\Support\Facades\Hash;
4 4
 
5
-$factory->define(App\Containers\User\Models\User::class, function (Faker\Generator $faker) {
5
+$factory->define(App\Containers\User\Models\User::class, function(Faker\Generator $faker) {
6 6
 
7 7
     return [
8 8
         'name'     => $faker->name,
Please login to merge, or discard this patch.
app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
             return;
33 33
         }
34 34
 
35
-        $url = ($url) ? : $this->baseUrl;
35
+        $url = ($url) ?: $this->baseUrl;
36 36
 
37 37
         $info = parse_url($url);
38 38
 
Please login to merge, or discard this patch.
app/Containers/User/UI/API/Tests/Functional/CreateAdminTest.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,10 +38,10 @@
 block discarded – undo
38 38
             'name'  => $data['name'],
39 39
         ], $response);
40 40
 
41
-         // assert response contain the token
41
+            // assert response contain the token
42 42
         $this->assertResponseContainKeys(['id', 'token'], $response);
43 43
 
44
-         // assert the data is stored in the database
44
+            // assert the data is stored in the database
45 45
         $this->seeInDatabase('users', ['email' => $data['email']]);
46 46
 
47 47
         $responseContent = $this->getResponseContent($response);
Please login to merge, or discard this patch.
app/Ship/Engine/Loaders/LocalizationLoaderTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
     }
33 33
 
34 34
     /**
35
-     * @param $directory
35
+     * @param string $directory
36 36
      * @param $containerName
37 37
      */
38 38
     private function loadLocals($directory, $containerName)
Please login to merge, or discard this patch.
app/Ship/Engine/Loaders/MigrationsLoaderTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
     }
37 37
 
38 38
     /**
39
-     * @param $directory
39
+     * @param string $directory
40 40
      */
41 41
     private function loadMigrations($directory)
42 42
     {
Please login to merge, or discard this patch.