CharifyCountriesTable::down() - Code Metrics - Inspection of "add countries container" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89477f...f97380 )

by Mahmoud

created 2016-09-26 14:50 UTC

CharifyCountriesTable::down() A

↳ Parent: CharifyCountriesTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	1
eloc	1
nc	1
nop	0

<?php

use Illuminate\Database\Migrations\Migration;

class CharifyCountriesTable extends Migration
namespace YourVendor;

class YourClass { }
{

    /**
     * Run the migrations.
     *
     * @return  void
     */
    public function up()
    {
//        Schema::table(\Config::get('countries.table_name'), function ($table) {

//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY country_code CHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_2 CHAR(2) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_3 CHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY region_code CHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY sub_region_code CHAR(3) NOT NULL DEFAULT ''");
//        });
    }


    /**
     * Reverse the migrations.
     *
     * @return  void
     */
    public function down()
    {
//        Schema::table(\Config::get('countries.table_name'), function ($table) {

//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY country_code VARCHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_2 VARCHAR(2) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_3 VARCHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY region_code VARCHAR(3) NOT NULL DEFAULT ''");
//            \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY sub_region_code VARCHAR(3) NOT NULL DEFAULT ''");
//        });
    }

}


1			<?php
2
3			use Illuminate\Database\Migrations\Migration;
4
5			class CharifyCountriesTable extends Migration
			0 ignored issues – show Coding Style Compatibility introduced 2016-09-26 14:59 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6			{
7
8			/**
9			* Run the migrations.
10			*
11			* @return void
12			*/
13			public function up()
14			{
15			// Schema::table(\Config::get('countries.table_name'), function ($table) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-26 14:59 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
16			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY country_code CHAR(3) NOT NULL DEFAULT ''");
17			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_2 CHAR(2) NOT NULL DEFAULT ''");
18			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_3 CHAR(3) NOT NULL DEFAULT ''");
19			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY region_code CHAR(3) NOT NULL DEFAULT ''");
20			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY sub_region_code CHAR(3) NOT NULL DEFAULT ''");
21			// });
22			}
23
24
25			/**
26			* Reverse the migrations.
27			*
28			* @return void
29			*/
30			public function down()
31			{
32			// Schema::table(\Config::get('countries.table_name'), function ($table) {
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-09-26 14:59 UTC by Report Bug Copy Issue Report `46%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
33			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY country_code VARCHAR(3) NOT NULL DEFAULT ''");
34			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_2 VARCHAR(2) NOT NULL DEFAULT ''");
35			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY iso_3166_3 VARCHAR(3) NOT NULL DEFAULT ''");
36			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY region_code VARCHAR(3) NOT NULL DEFAULT ''");
37			// \DB::statement("ALTER TABLE " . \DB::getTablePrefix() . \Config::get('countries.table_name') . " MODIFY sub_region_code VARCHAR(3) NOT NULL DEFAULT ''");
38			// });
39			}
40
41			}
42

Porto-SAP / Hello-API

Push — master ( 89477f...f97380 )

CharifyCountriesTable::down() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like