CreateUserWithoutCredentialsAction::__construct() - Code Metrics - Inspection of "S: add ability to create users by device id" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 012634...6d13cc )

by Mahmoud

created 2016-07-19 17:24 UTC

CreateUserWithoutCredentialsAction::__construct() A

↳ Parent: CreateUserWithoutCredentialsAction

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace App\Containers\User\Actions;

use App\Containers\User\Services\CreateUserService;
use App\Port\Action\Abstracts\Action;

/**
 * Class CreateUserWithoutCredentialsAction.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class CreateUserWithoutCredentialsAction extends Action
{

    /**
     * @var  \App\Containers\User\Actions\CreateUserService
     */
    private $createUserService;

    /**
     * CreateUserWithCredentialsAction constructor.
     *
     * @param \App\Containers\User\Services\CreateUserService $createUserService
     */
    public function __construct(CreateUserService $createUserService)
    {
        $this->createUserService = $createUserService;

    }

    /**
     * @param            $agentId
     * @param null       $platform
     * @param null       $device
     * @param bool|false $login
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return  mixed
     */
    public function run($agentId, $device = null, $platform = null)
    {
        $user = $this->createUserService->byAgent($agentId, $device, $platform);

        return $user;
    }
}


1			<?php
2
3			namespace App\Containers\User\Actions;
4
5			use App\Containers\User\Services\CreateUserService;
6			use App\Port\Action\Abstracts\Action;
7
8			/**
9			* Class CreateUserWithoutCredentialsAction.
10			*
11			* @author Mahmoud Zalt <[email protected]>
12			*/
13			class CreateUserWithoutCredentialsAction extends Action
14			{
15
16			/**
17			* @var \App\Containers\User\Actions\CreateUserService
18			*/
19			private $createUserService;
20
21			/**
22			* CreateUserWithCredentialsAction constructor.
23			*
24			* @param \App\Containers\User\Services\CreateUserService $createUserService
25			*/
26			public function __construct(CreateUserService $createUserService)
27			{
28			$this->createUserService = $createUserService;
			0 ignored issues – show Documentation Bug introduced 2016-07-19 17:28 UTC by Report Bug Copy Issue Report It seems like `$createUserService` of type `object<App\Containers\Us...ices\CreateUserService>` is incompatible with the declared type `object<App\Containers\Us...ions\CreateUserService>` of property `$createUserService`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
29			}
30
31			/**
32			* @param $agentId
33			* @param null $platform
34			* @param null $device
35			* @param bool\|false $login
			0 ignored issues – show Bug introduced 2016-07-19 17:28 UTC by Report Bug Copy Issue Report There is no parameter named `$login`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
36			*
37			* @return mixed
38			*/
39			public function run($agentId, $device = null, $platform = null)
40			{
41			$user = $this->createUserService->byAgent($agentId, $device, $platform);
42
43			return $user;
44			}
45			}
46

Porto-SAP / Hello-API

Push — master ( 012634...6d13cc )

CreateUserWithoutCredentialsAction::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like