Localization - Code Metrics - Inspection of "just extend the Laravel Application" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ea048a...f42f25 )

by Mahmoud

created 2017-02-28 21:33 UTC

Localization A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	0
dl	0
loc	64
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	handle()	17	1
A	validateLanguage()	10	2
A	findLanguage()	5	2
A	getSupportedLanguages()	4	1

<?php

namespace App\Containers\Localization\Middlewares;

use Closure;
use App;
use Config;

/**
 * Class Localization
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class Localization
{
    /**
     * Handle an incoming request.
     *
     * @param  \Illuminate\Http\Request $request
     * @param  \Closure                 $next
     *
     * @return mixed
     */
    public function handle($request, Closure $next)
    {
        // find and validate the lang on that request
        $lang = $this->validateLanguage($this->findLanguage($request));

        // set the local language
        App::setLocale($lang);

        // get the response after the request is done
        $response = $next($request);

        // set Content Languages header in the response
        $response->headers->set('Content-Language', $lang);

        // return the response
        return $response;
    }

    /**
     * @param $lang
     *
     * @return string|Exception
     */
    private function validateLanguage($lang)
    {
        // check the languages defined is supported
        if (!array_key_exists($lang, $this->getSupportedLanguages())) {
            // respond with error
            $lang = abort(403, 'Language not supported.');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        }

        return $lang;
    }

    /**
     * @param $request
     *
     * @return  string
     */
    private function findLanguage($request)
    {
        // read the language from the request header, if the header is missed, take the default local language
        return $request->header('Content-Language') ? : Config::get('app.locale');
    }

    /**
     * @return array
     */
    private function getSupportedLanguages()
    {
        return Config::get('localization.supported_languages');
    }

}


1			<?php
2
3			namespace App\Containers\Localization\Middlewares;
4
5			use Closure;
6			use App;
7			use Config;
8
9			/**
10			* Class Localization
11			*
12			* @author Mahmoud Zalt <[email protected]>
13			*/
14			class Localization
15			{
16			/**
17			* Handle an incoming request.
18			*
19			* @param \Illuminate\Http\Request $request
20			* @param \Closure $next
21			*
22			* @return mixed
23			*/
24			public function handle($request, Closure $next)
25			{
26			// find and validate the lang on that request
27			$lang = $this->validateLanguage($this->findLanguage($request));
28
29			// set the local language
30			App::setLocale($lang);
31
32			// get the response after the request is done
33			$response = $next($request);
34
35			// set Content Languages header in the response
36			$response->headers->set('Content-Language', $lang);
37
38			// return the response
39			return $response;
40			}
41
42			/**
43			* @param $lang
44			*
45			* @return string\|Exception
46			*/
47			private function validateLanguage($lang)
48			{
49			// check the languages defined is supported
50			if (!array_key_exists($lang, $this->getSupportedLanguages())) {
51			// respond with error
52			$lang = abort(403, 'Language not supported.');
			0 ignored issues – show Bug introduced 2017-02-24 20:45 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$lang` is correct as `abort(403, 'Language not supported.')` (which targets `abort()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
53			}
54
55			return $lang;
56			}
57
58			/**
59			* @param $request
60			*
61			* @return string
62			*/
63			private function findLanguage($request)
64			{
65			// read the language from the request header, if the header is missed, take the default local language
66			return $request->header('Content-Language') ? : Config::get('app.locale');
67			}
68
69			/**
70			* @return array
71			*/
72			private function getSupportedLanguages()
73			{
74			return Config::get('localization.supported_languages');
75			}
76
77			}
78

Porto-SAP / Hello-API

Push — master ( ea048a...f42f25 )

Localization A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like