Porto-SAP / Hello-API

app/Ship/Features/Tests/PhpUnit/TestsAuthHelperTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -154,7 +154,7 @@
     }
 
     /**
-     * @param $user
+     * @param User $user
      * @param $access
      *
      * @return  mixed

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use App;
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
 use App\Containers\User\Models\User;
-use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Support\Facades\Hash;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
      */
     private function findOrCreateTestingUser($userDetails, $access)
     {
-        return $this->testingUser ? : $this->createTestingUser($userDetails, $access);
+        return $this->testingUser ?: $this->createTestingUser($userDetails, $access);
     }
 
     /**
@@ -126,7 +126,7 @@ 
         ];
 
         // if no user detail provided, use the default details, to find the password or generate one before encoding it
-        return $this->prepareUserPassword($userDetails ? : $defaultUserDetails);;
+        return $this->prepareUserPassword($userDetails ?: $defaultUserDetails); ;
     }
 
     /**
@@ -161,7 +161,7 @@ 
      */
     private function setupTestingUserAccess($user, $access)
     {
-        $access = $access ? : $this->getAccess();
+        $access = $access ?: $this->getAccess();
 
         $user = $this->setupTestingUserPermissions($user, $access);
         $user = $this->setupTestingUserRoles($user, $access);

app/Ship/Features/Tests/PhpUnit/TestsRequestHelperTrait.php

Doc Comments +3 added lines, -5 removed lines

@@ -63,9 +63,7 @@ 
 
     /**
      * @param        $this ->endpointUrl
-     * @param string $this ->endpointVerb
      * @param array  $data
-     * @param bool   $protected
      * @param array  $headers
      *
      * @return  mixed
@@ -91,7 +89,7 @@ 
      * @param bool   $skipEncoding
      * @param string $replace
      *
-     * @return  mixed
+     * @return  TestsRequestHelperTrait
      */
     public function injectId($id, $skipEncoding = false, $replace = '{id}')
     {
@@ -108,7 +106,7 @@ 
      *
      * to be used as follow: $this->endpoint('verb@url')->makeCall($data);
      *
-     * @param $endpoint
+     * @param string $endpoint
      *
      * @return  $this
      */
@@ -282,7 +280,7 @@ 
     }
 
     /**
-     * @param $separator
+     * @param string $separator
      */
     private function validateEndpointFormat($separator)
     {

app/Ship/Features/Tests/PhpUnit/TestsResponseHelperTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $httpResponse
      */
     public function assertResponseContainKeys($keys, $httpResponse)

app/Containers/User/Data/Factories/UserFactory.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Illuminate\Support\Facades\Hash;
 
-$factory->define(App\Containers\User\Models\User::class, function (Faker\Generator $faker) {
+$factory->define(App\Containers\User\Models\User::class, function(Faker\Generator $faker) {
 
     return [
         'name'     => $faker->name,

app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             return;
         }
 
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Containers/User/UI/API/Tests/Functional/CreateAdminTest.php

Indentation +2 added lines, -2 removed lines

@@ -38,10 +38,10 @@
             'name'  => $data['name'],
         ], $response);
 
-         // assert response contain the token
+            // assert response contain the token
         $this->assertResponseContainKeys(['id', 'token'], $response);
 
-         // assert the data is stored in the database
+            // assert the data is stored in the database
         $this->seeInDatabase('users', ['email' => $data['email']]);
 
         $responseContent = $this->getResponseContent($response);

app/Ship/Engine/Loaders/LocalizationLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     }
 
     /**
-     * @param $directory
+     * @param string $directory
      * @param $containerName
      */
     private function loadLocals($directory, $containerName)

app/Ship/Engine/Loaders/MigrationsLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     }
 
     /**
-     * @param $directory
+     * @param string $directory
      */
     private function loadMigrations($directory)
     {

app/Ship/Engine/Loaders/RoutesLoaderTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 
     /**
      * @param $file
-     * @param $controllerNamespace
+     * @param string $controllerNamespace
      */
     private function loadWebRoute($file, $controllerNamespace)
     {
@@ -145,7 +145,7 @@ 
     /**
      * @param \Symfony\Component\Finder\SplFileInfo $file
      *
-     * @return  mixed
+     * @return  string
      */
     private function getRouteFileNameWithoutExtension(SplFileInfo $file)
     {

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
         $this->webRouter->group([
             'middleware' => ['web'],
             'namespace'  => $controllerNamespace,
-        ], function (LaravelRouter $router) use ($file) {
+        ], function(LaravelRouter $router) use ($file) {
             require $file->getPathname();
         });
     }
@@ -100,7 +100,7 @@ 
         $apiVersionNumber = $this->getRouteFileVersionNumber($file);
 
         $this->apiRouter->version('v' . $apiVersionNumber,
-            function (DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
+            function(DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
 
                 $controllerNamespace = $containersNamespace . '\\Containers\\' . basename($containerPath) . '\\UI\API\Controllers';
 
@@ -113,7 +113,7 @@ 
                     'limit'      => Config::get('hello.api.limit'),
                     // The API limit expiry time.
                     'expires'    => Config::get('hello.api.limit_expires'),
-                ], function ($router) use ($file) {
+                ], function($router) use ($file) {
 
                     require $file->getPathname();