Controller - Code Metrics - Inspection of "ignore incomplete containers" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 857394...4794c5 )

by Mahmoud

created 2017-02-05 21:20 UTC

Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	2
dl	0
loc	21
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	confirmUserEmail()	0	10	1

<?php

namespace App\Containers\Email\UI\WEB\Controllers;

use App\Containers\Email\Actions\ValidateUserEmailByConfirmationCodeAction;
use App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest;
use App\Port\Controller\Abstracts\PortWebController;
use Illuminate\Support\Facades\Config;

/**
 * Class Controller.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class Controller extends PortWebController
{

    /**
     * @param \App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest $request
     * @param \App\Containers\Email\Actions\ValidateUserEmailByConfirmationCodeAction $action
     *
     * @return  \Illuminate\Http\RedirectResponse|\Illuminate\Routing\Redirector
     */
    public function confirmUserEmail(
        ConfirmUserEmailRequest $request,
        ValidateUserEmailByConfirmationCodeAction $action
    ) {
        // validate the confirmation code and update user status is code is valid
        $action->run($request->id, $request->code);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // redirect to the app URL
        return redirect(Config::get('app.url'));
    }

}


1			<?php
2
3			namespace App\Containers\Email\UI\WEB\Controllers;
4
5			use App\Containers\Email\Actions\ValidateUserEmailByConfirmationCodeAction;
6			use App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest;
7			use App\Port\Controller\Abstracts\PortWebController;
8			use Illuminate\Support\Facades\Config;
9
10			/**
11			* Class Controller.
12			*
13			* @author Mahmoud Zalt <[email protected]>
14			*/
15			class Controller extends PortWebController
16			{
17
18			/**
19			* @param \App\Containers\Email\UI\API\Requests\ConfirmUserEmailRequest $request
20			* @param \App\Containers\Email\Actions\ValidateUserEmailByConfirmationCodeAction $action
21			*
22			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\Routing\Redirector
23			*/
24			public function confirmUserEmail(
25			ConfirmUserEmailRequest $request,
26			ValidateUserEmailByConfirmationCodeAction $action
27			) {
28			// validate the confirmation code and update user status is code is valid
29			$action->run($request->id, $request->code);
			0 ignored issues – show Documentation introduced 2016-08-18 02:39 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Containers\Em...onfirmUserEmailRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-08-18 02:39 UTC by Report Bug Copy Issue Report The property `code` does not exist on `object<App\Containers\Em...onfirmUserEmailRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30
31			// redirect to the app URL
32			return redirect(Config::get('app.url'));
33			}
34
35			}
36

Porto-SAP / Hello-API

Push — master ( 857394...4794c5 )

Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like