CreateApplicationTask - Code Metrics - Inspection of "ignore incomplete containers" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 857394...4794c5 )

by Mahmoud

created 2017-02-05 21:20 UTC

CreateApplicationTask A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	0
cbo	3
dl	0
loc	35
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	run()	0	9	1

<?php

namespace App\Containers\Application\Tasks;

use App\Containers\Application\Data\Repositories\ApplicationRepository;
use App\Containers\Application\Models\Application;
use App\Port\Task\Abstracts\Task;

/**
 * Class CreateApplicationTask.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class CreateApplicationTask extends Task
{

    /**
     * @var  \App\Containers\Application\Data\Repositories\ApplicationRepository
     */
    private $applicationRepository;

    /**
     * CreateApplicationTask constructor.
     *
     * @param \App\Containers\Application\Data\Repositories\ApplicationRepository $applicationRepository
     */
    public function __construct(ApplicationRepository $applicationRepository)
    {
        $this->applicationRepository = $applicationRepository;
    }

    /**
     * @param $name
     * @param $userId
     *
     * @return  \App\Containers\Application\Models\Application|mixed
     */
    public function run($name, $userId)
    {
        $application = new Application();
        $application->name = $name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $application->user()->associate($userId);
        $application = $this->applicationRepository->create($application->toArray());

        return $application;
    }

}


1			<?php
2
3			namespace App\Containers\Application\Tasks;
4
5			use App\Containers\Application\Data\Repositories\ApplicationRepository;
6			use App\Containers\Application\Models\Application;
7			use App\Port\Task\Abstracts\Task;
8
9			/**
10			* Class CreateApplicationTask.
11			*
12			* @author Mahmoud Zalt <[email protected]>
13			*/
14			class CreateApplicationTask extends Task
15			{
16
17			/**
18			* @var \App\Containers\Application\Data\Repositories\ApplicationRepository
19			*/
20			private $applicationRepository;
21
22			/**
23			* CreateApplicationTask constructor.
24			*
25			* @param \App\Containers\Application\Data\Repositories\ApplicationRepository $applicationRepository
26			*/
27			public function __construct(ApplicationRepository $applicationRepository)
28			{
29			$this->applicationRepository = $applicationRepository;
30			}
31
32			/**
33			* @param $name
34			* @param $userId
35			*
36			* @return \App\Containers\Application\Models\Application\|mixed
37			*/
38			public function run($name, $userId)
39			{
40			$application = new Application();
41			$application->name = $name;
			0 ignored issues – show Documentation introduced 2016-12-01 18:24 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Containers\Ap...ion\Models\Application>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
42			$application->user()->associate($userId);
43			$application = $this->applicationRepository->create($application->toArray());
44
45			return $application;
46			}
47
48			}
49

Porto-SAP / Hello-API

Push — master ( 857394...4794c5 )

CreateApplicationTask A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like