Controller - Code Metrics - Inspection of "add and activate admin views" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( effffd...96380e )

by Mahmoud

created 2016-09-09 20:43 UTC

Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	5
c	1
b	0
f	1
lcom	0
cbo	3
dl	0
loc	50
rs	10

4 Methods

Rating	Name	Size	Complexity
A	showLoginPage()	4	1
A	loginAdmin()	10	2
A	showDashboardPage()	4	1
A	logoutAdmin()	6	1

<?php

namespace App\Containers\Authentication\UI\WEB\Controllers;

use App\Containers\Authentication\Actions\WebAdminLoginAction;
use App\Containers\Authentication\Actions\WebLogoutAction;
use App\Containers\Authentication\UI\WEB\Requests\LoginRequest;
use App\Port\Controller\Abstracts\PortWebController;

/**
 * Class Controller
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class Controller extends PortWebController
{

    /**
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showLoginPage()
    {
        return view('login');
    }

    /**
     * @param \App\Containers\Authentication\UI\WEB\Requests\LoginRequest $request
     * @param \App\Containers\Authentication\Actions\WebAdminLoginAction  $action
     *
     * @return  $this|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function loginAdmin(LoginRequest $request, WebAdminLoginAction $action)
    {
        $result = $action->run($request->email, $request->password, $request->remember_me);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if (is_array($result)) {
            return view('login')->with($result);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        }

        return view('dashboard');
    }

    /**
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showDashboardPage()
    {
        return view('dashboard');
    }

    /**
     * @param \App\Containers\Authentication\Actions\WebLogoutAction $action
     *
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function logoutAdmin(WebLogoutAction $action)
    {
        $action->run();

        return view('login');
    }


}


1			<?php
2
3			namespace App\Containers\Authentication\UI\WEB\Controllers;
4
5			use App\Containers\Authentication\Actions\WebAdminLoginAction;
6			use App\Containers\Authentication\Actions\WebLogoutAction;
7			use App\Containers\Authentication\UI\WEB\Requests\LoginRequest;
8			use App\Port\Controller\Abstracts\PortWebController;
9
10			/**
11			* Class Controller
12			*
13			* @author Mahmoud Zalt <[email protected]>
14			*/
15			class Controller extends PortWebController
16			{
17
18			/**
19			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
20			*/
21			public function showLoginPage()
22			{
23			return view('login');
24			}
25
26			/**
27			* @param \App\Containers\Authentication\UI\WEB\Requests\LoginRequest $request
28			* @param \App\Containers\Authentication\Actions\WebAdminLoginAction $action
29			*
30			* @return $this\|\Illuminate\Contracts\View\Factory\|\Illuminate\View\View
31			*/
32			public function loginAdmin(LoginRequest $request, WebAdminLoginAction $action)
33			{
34			$result = $action->run($request->email, $request->password, $request->remember_me);
			0 ignored issues – show Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `remember_me` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
35
36			if (is_array($result)) {
37			return view('login')->with($result);
			0 ignored issues – show Bug introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
38			}
39
40			return view('dashboard');
41			}
42
43			/**
44			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
45			*/
46			public function showDashboardPage()
47			{
48			return view('dashboard');
49			}
50
51			/**
52			* @param \App\Containers\Authentication\Actions\WebLogoutAction $action
53			*
54			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
55			*/
56			public function logoutAdmin(WebLogoutAction $action)
57			{
58			$action->run();
59
60			return view('login');
61			}
62
63
64			}
65

Porto-SAP / Hello-API

Push — master ( effffd...96380e )

Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like