Porto-SAP / Hello-API

app/Containers/Authorization/UI/API/Tests/Functional/FindRoleByNameTest.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace App\Containers\Order\UI\API\Tests\Functional;
 
 use App\Containers\Order\Models\Order;
-use App\Containers\Invoice\Models\Invoice;
-use App\Containers\User\Models\User;
 use App\Port\Test\PHPUnit\Abstracts\TestCase;
-use Vinkla\Hashids\Facades\Hashids;
 
 /**
  * Class FindRoleByNameTest.

app/Containers/Authorization/UI/API/Tests/Functional/ListPermissionsTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Containers\Authorization\UI\API\Tests\Functional;
 
-use App\Containers\Authorization\Models\User;
 use App\Port\Test\PHPUnit\Abstracts\TestCase;
 
 /**

app/Port/Route/Loaders/RoutesLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
     /**
      * @param \Symfony\Component\Finder\SplFileInfo $file
      *
-     * @return  mixed
+     * @return  string
      */
     private function getRouteFileNameWithoutExtension(SplFileInfo $file)
     {

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
                 $apiVersionNumber = $this->getRouteFileVersionNumber($file);
 
                 $this->apiRouter->version('v' . $apiVersionNumber,
-                    function (DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
+                    function(DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
 
                         $controllerNamespace = $containersNamespace . '\\Containers\\' . basename($containerPath) . '\\UI\API\Controllers';
 
@@ -67,7 +67,7 @@ 
                             'limit'      => Config::get('hello.api.limit'),
                             // The API limit expiry time.
                             'expires'    => Config::get('hello.api.limit_expires'),
-                        ], function ($router) use ($file) {
+                        ], function($router) use ($file) {
 
                             require $file->getPathname();
 
@@ -101,7 +101,7 @@ 
                 $this->webRouter->group([
                     'middleware' => ['web'],
                     'namespace'  => $controllerNamespace,
-                ], function (LaravelRouter $router) use ($file) {
+                ], function(LaravelRouter $router) use ($file) {
                     require $file->getPathname();
                 });
             }

app/Port/Test/PHPUnit/Traits/TestingTrait.php

Doc Comments +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
     public $loggedInTestingUser;
 
     /**
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param string $verb
      * @param array  $data
      * @param bool   $protected
@@ -133,7 +133,7 @@ 
     }
 
     /**
-     * @return  App\Containers\User\Models\User|mixed
+     * @return  User
      */
     public function getLoggedInTestingAdmin()
     {
@@ -171,7 +171,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingUser($userDetails = null)
     {
@@ -202,7 +202,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingAdmin($userDetails = null)
     {
@@ -218,7 +218,7 @@ 
      *
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingDeveloper($userDetails = null)
     {
@@ -233,7 +233,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Port\Test\PHPUnit\Traits;
 
 use App;
-use App\Containers\Application\Actions\CreateApplicationWithTokenAction;
 use App\Containers\Authorization\Models\Role;
 use App\Containers\Authorization\Tasks\AssignRoleTask;
 use App\Containers\User\Actions\CreateUserAction;

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Containers/User/UI/API/Transformers/UserTransformer.php

Indentation +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     public function transform(User $user)
     {
 
-      $response = [
+        $response = [
             'id'                   => $user->getHashedKey(),
             'name'                 => $user->name,
             'email'                => $user->email,

app/Port/Criteria/Eloquent/ThisUserCriteria.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
      */
     public function apply($model, PrettusRepositoryInterface $repository)
     {
-        if(!$this->userId){
+        if (!$this->userId) {
             $this->userId = Auth::user()->id;
         }
 

app/Port/Criteria/Eloquent/CountCriteria.php

Spacing +1 added lines, -1 removed lines

@@ -37,6 +37,6 @@
      */
     public function apply($model, PrettusRepositoryInterface $repository)
     {
-        return DB::table($model->getModel()->getTable())->select('*', DB::raw('count('.$this->field.') as total_count'))->groupBy($this->field);
+        return DB::table($model->getModel()->getTable())->select('*', DB::raw('count(' . $this->field . ') as total_count'))->groupBy($this->field);
     }
 }

app/Port/Test/PHPUnit/Abstracts/TestCase.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         $this->baseUrl = env('API_FULL_URL'); // this reads the value from `phpunit.xml` during testing
 
         // override the default subDomain of the base URL when subDomain property is defined inside a test
-        if(property_exists($this, 'subDomain')){
+        if (property_exists($this, 'subDomain')) {
             $this->overrideSubDomain($this->subDomain);
         }
 

app/Containers/Authorization/UI/API/Tests/Functional/ListRolesTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Containers\Authorization\UI\API\Tests\Functional;
 
-use App\Containers\Authorization\Models\User;
 use App\Port\Test\PHPUnit\Abstracts\TestCase;
 
 /**