Porto-SAP / Hello-API

app/Ship/Engine/Loaders/RoutesLoaderTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -77,7 +77,7 @@ 
 
     /**
      * @param $file
-     * @param $controllerNamespace
+     * @param string $controllerNamespace
      */
     private function loadWebRoute($file, $controllerNamespace)
     {
@@ -145,7 +145,7 @@ 
     /**
      * @param \Symfony\Component\Finder\SplFileInfo $file
      *
-     * @return  mixed
+     * @return  string
      */
     private function getRouteFileNameWithoutExtension(SplFileInfo $file)
     {

Spacing +3 added lines, -3 removed lines

@@ -84,7 +84,7 @@ 
         $this->webRouter->group([
             'middleware' => ['web'],
             'namespace'  => $controllerNamespace,
-        ], function (LaravelRouter $router) use ($file) {
+        ], function(LaravelRouter $router) use ($file) {
             require $file->getPathname();
         });
     }
@@ -100,7 +100,7 @@ 
         $apiVersionNumber = $this->getRouteFileVersionNumber($file);
 
         $this->apiRouter->version('v' . $apiVersionNumber,
-            function (DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
+            function(DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
 
                 $controllerNamespace = $containersNamespace . '\\Containers\\' . basename($containerPath) . '\\UI\API\Controllers';
 
@@ -113,7 +113,7 @@ 
                     'limit'      => Config::get('hello.api.limit'),
                     // The API limit expiry time.
                     'expires'    => Config::get('hello.api.limit_expires'),
-                ], function ($router) use ($file) {
+                ], function($router) use ($file) {
 
                     require $file->getPathname();
 

app/Ship/Engine/Loaders/ViewsLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
     }
 
     /**
-     * @param $directory
+     * @param string $directory
      * @param $containerName
      */
     private function loadViews($directory, $containerName)

app/Containers/Authorization/Traits/AuthorizationTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 trait AuthorizationTrait
 {
     /**
-     * @return  \App\Containers\User\Models\User|null
+     * @return  \Illuminate\Contracts\Auth\Authenticatable|null
      */
     public function getUser()
     {

app/Ship/Parents/Requests/Request.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Ship\Parents\Requests;
 
-use App\Containers\Authorization\Traits\AuthorizationTrait;
 use App\Ship\Engine\Traits\HashIdTrait;
 use Illuminate\Foundation\Http\FormRequest as LaravelFormRequest;
 

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     public function hasAccess(User $user = null)
     {
         // if not in parameters, take from the request object {$this}
-        $user = $user ? : $this->user();
+        $user = $user ?: $this->user();
 
         $hasAccess = array_merge(
             $this->hasAnyPermissionAccess($user),

app/Ship/Parents/Requests/RequestTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
      * To call functions and compare their bool responses to determine
      * if the user can proceed with the request or not.
      *
-     * @param array $functions
+     * @param string[] $functions
      *
      * @return  bool
      */

Unused Use Statements -3 removed lines

@@ -2,11 +2,8 @@
 
 namespace App\Ship\Parents\Requests;
 
-use App\Containers\Authorization\Traits\AuthorizationTrait;
-use App\Ship\Engine\Traits\HashIdTrait;
 use App\Ship\Features\Exceptions\ValidationFailedException;
 use Illuminate\Contracts\Validation\Validator;
-use Illuminate\Foundation\Http\FormRequest as LaravelFormRequest;
 
 /**
  * Class RequestTrait

Spacing +2 added lines, -2 removed lines

@@ -125,7 +125,7 @@ 
 
         $permissions = explode('|', $this->access['permissions']);
 
-        $hasAccess = array_map(function ($permission) use ($user) {
+        $hasAccess = array_map(function($permission) use ($user) {
             // Note: internal return
             return $user->hasPermissionTo($permission);
         }, $permissions);
@@ -146,7 +146,7 @@ 
 
         $roles = explode('|', $this->access['roles']);
 
-        $hasAccess = array_map(function ($role) use ($user) {
+        $hasAccess = array_map(function($role) use ($user) {
             // Note: internal return
             return $user->hasRole($role);
         }, $roles);

app/Containers/User/UI/API/Routes/CreateAdmin.v1.private.php

Indentation +1 added lines, -1 removed lines

@@ -42,6 +42,6 @@
 $router->post('admins', [
     'uses'  => 'Controller@createAdmin',
     'middleware' => [
-      'api.auth',
+        'api.auth',
     ],
 ]);

app/Ship/Parents/Tests/PhpUnit/TestCase.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Ship\Parents\Tests\PhpUnit;
 
 use App\Ship\Engine\Traits\HashIdTrait;
-use App\Ship\Features\Tests\PhpUnit\TestingTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsAuthHelperTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsCustomHelperTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsMockHelperTrait;

app/Ship/Engine/Traits/HashIdTrait.php

Doc Comments +3 added lines, -3 removed lines

@@ -182,7 +182,7 @@ 
     /**
      * @param $subject
      * @param $findKey
-     * @param $callback
+     * @param \Closure $callback
      *
      * @return  array
      */
@@ -206,7 +206,7 @@ 
     }
 
     /**
-     * @param $search
+     * @param string $search
      * @param $subject
      *
      * @return  mixed
@@ -225,7 +225,7 @@ 
     }
 
     /**
-     * @param $needle
+     * @param string $needle
      * @param $haystack
      *
      * @return  int

Spacing +4 added lines, -4 removed lines

@@ -29,7 +29,7 @@ 
     public function runEndpointsHashedIdsDecoder()
     {
         if (Config::get('hello.hash-id')) {
-            Route::bind('id', function ($id, $route) {
+            Route::bind('id', function($id, $route) {
                 // skip decoding some endpoints
                 if (!in_array($route->uri(), $this->skippedEndpoints)) {
 
@@ -58,7 +58,7 @@ 
     {
         // hash the ID only if hash-id enabled in the config
         if (Config::get('hello.hash-id')) {
-            return $this->encoder(($key) ? : $this->getKey());
+            return $this->encoder(($key) ?: $this->getKey());
         }
 
         return $this->getKey();
@@ -143,7 +143,7 @@ 
         // get the last part of the key, which should be the ID that needs decoding
         $idToDecode = substr($key, strrpos($key, '.*.') + 3);
 
-        array_walk_recursive($requestData, function (&$value, $key) use ($idToDecode) {
+        array_walk_recursive($requestData, function(&$value, $key) use ($idToDecode) {
 
             if ($key == $idToDecode) {
 
@@ -162,7 +162,7 @@ 
 
         $idToDecode = $this->removeLastOccurrenceFromString($key, '.*');
 
-        $this->findKeyAndReturnValue($requestData, $idToDecode, function ($ids) {
+        $this->findKeyAndReturnValue($requestData, $idToDecode, function($ids) {
 
             if (!is_array($ids)) {
                 throw new IncorrectIdException('Expected ID\'s to be in array. Please wrap your ID\'s in an Array and send them back.');

app/Ship/Features/Validations/ValidationTrait.php

Spacing +2 added lines, -2 removed lines

@@ -18,7 +18,7 @@ 
     public function extendValidationRules()
     {
         // Validate String contains no space.
-        Validator::extend('no_spaces', function ($attribute, $value, $parameters, $validator) {
+        Validator::extend('no_spaces', function($attribute, $value, $parameters, $validator) {
             return preg_match('/^\S*$/u', $value);
         }, ['String should not contain space.']);
 
@@ -26,7 +26,7 @@ 
         // Usage: unique_composite:table,this-attribute-column,the-other-attribute-column
         // Example:    'values'               => 'required|unique_composite:item_variant_values,value,item_variant_name_id',
         //             'item_variant_name_id' => 'required',
-        Validator::extend('unique_composite', function ($attribute, $value, $parameters, $validator) {
+        Validator::extend('unique_composite', function($attribute, $value, $parameters, $validator) {
 
             $queryBuilder = \DB::table($parameters[0]);