App\Port\Request\Traits\RequestTrait

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	validatePermission()	0	24	4

<?php

namespace App\Port\Request\Traits;

/**
 * Class RequestTrait
 *
 * @author  Mahmoud Zalt  <mahmoud@zalt.me>
 */
trait RequestTrait
{

    /**
     * This function will be called from the Requests (authorize) to check if a user
     * has permission to perform an action.
     * User can set multiple permissions (separated with "|") and if the user has
     * any of the permissions, he will be authorize to proceed with this action.
     *
     * @return  bool
     */
    public function validatePermission()
    {
        // $this->access is optionally set on the Request

        // allow access when the access is not defined
        // allow access when nothing no roles or permissions are declared
        if (!isset($this->access) || !isset($this->access['permission'])) {

The property access does not exist. Did you maybe forget to declare it?

            return true;
        }

        // allow access if has permission set but is empty or null
        if(!$this->access['permission']){
            return true;
        }

        $permissions = explode('|', $this->access['permission']);

        $hasPermission = array_map(function($permission) {
            return $this->user()->hasPermissionTo($permission);

It seems like user() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }, $permissions);

        // allow access if user has access to any of the defined permissions.
        return in_array(true, $hasPermission);
    }

}