Porto-SAP / Hello-API

app/Ship/Engine/Loaders/SeederLoaderTrait.php

Doc Comments +4 added lines, -4 removed lines

@@ -70,8 +70,8 @@ 
     }
 
     /**
-     * @param array $directories
-     * @param       $seedersClasses
+     * @param string[] $directories
+     * @param       Collection $seedersClasses
      *
      * @return  mixed
      */
@@ -103,7 +103,7 @@ 
     /**
      * @param $seedersClasses
      *
-     * @return  \Illuminate\Support\Collection|static
+     * @return  Collection|null
      */
     private function sortSeeders($seedersClasses)
     {
@@ -140,7 +140,7 @@ 
     }
 
     /**
-     * @param $seedersClasses
+     * @param Collection|null $seedersClasses
      */
     private function loadSeeders($seedersClasses)
     {

Spacing +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
             }
 
             // sort the classes that needed to be ordered
-            $orderedSeederClasses = $orderedSeederClasses->sortBy(function ($seederFullClassName) {
+            $orderedSeederClasses = $orderedSeederClasses->sortBy(function($seederFullClassName) {
                 // get the order number form the end of each class name
                 $orderNumber = substr($seederFullClassName, strpos($seederFullClassName, "_") + 1);
 

app/Ship/Features/Tests/PhpUnit/GeneralTestsHelpersTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
      *
      * Example: you give it ('users/{id}/stores', 100) it returns 'users/100/stores'
      *
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param        $id
      * @param bool   $skipEncoding
      * @param string $replace
@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Ship\Features\Tests\PhpUnit;
 
 use App;
-use Artisan;
 use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Http\Response;
 use Illuminate\Http\UploadedFile;

app/Ship/Features/Tests/PhpUnit/TestingUserTrait.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use App;
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
 use App\Containers\User\Models\User;
-use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Support\Facades\Hash;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
     public function createTestingUser($access = null, $userDetails = null)
     {
         // if no user detail provided, use the default details.
-        $userDetails = $userDetails ? : [
+        $userDetails = $userDetails ?: [
             'name'     => 'Testing User',
             'email'    => $this->faker->email,
             'password' => 'testing-pass',
@@ -112,7 +112,7 @@ 
         ]);
 
         // assign roles and permissions
-        $user = $this->setupTestingUserAccess($user, $access ? : (isset($this->access) ? $this->access : null));
+        $user = $this->setupTestingUserAccess($user, $access ?: (isset($this->access) ? $this->access : null));
 
         // log the user in
         $user = App::make(ApiLoginThisUserObjectTask::class)->run($user);

app/Ship/Parents/Tests/PhpUnit/TestCase.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App\Ship\Features\Tests\PhpUnit\CustomTestsHelpersTrait;
 use App\Ship\Features\Tests\PhpUnit\GeneralTestsHelpersTrait;
-use App\Ship\Features\Tests\PhpUnit\TestingTrait;
 use App\Ship\Features\Tests\PhpUnit\TestingUserTrait;
 use Faker\Generator;
 use Illuminate\Contracts\Console\Kernel as LaravelKernel;

app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App;
 use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 
 /**
  * Class TestCaseTrait

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Ship/Engine/Loaders/FactoriesLoaderTrait.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     {
         $newFactoriesPath = '/app/Ship/Engine/Loaders/FactoryMixer';
 
-        App::singleton(Factory::class, function ($app) use ($newFactoriesPath) {
+        App::singleton(Factory::class, function($app) use ($newFactoriesPath) {
             $faker = $app->make(Generator::class);
 
             return Factory::construct($faker, base_path() . $newFactoriesPath);

app/Ship/Engine/Loaders/MigrationsLoaderTrait.php

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
     {
         if (File::isDirectory($directory)) {
 
-            App::afterResolving('migrator', function ($migrator) use ($directory) {
+            App::afterResolving('migrator', function($migrator) use ($directory) {
                 foreach ((array)$directory as $path) {
                     $migrator->path($path);
                 }

app/Ship/Engine/Traits/FractalTrait.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
         // if DataArray `\League\Fractal\Serializer\DataArraySerializer` do noting since it's set by default by the Dingo API
         if ($serializerName !== 'DataArray') {
-            app('Dingo\Api\Transformer\Factory')->setAdapter(function () use ($serializerName) {
+            app('Dingo\Api\Transformer\Factory')->setAdapter(function() use ($serializerName) {
                 switch ($serializerName) {
                     case 'JsonApi':
                         $serializer = new \League\Fractal\Serializer\JsonApiSerializer(Config::get('api.domain'));

app/Ship/Features/Criterias/Eloquent/CountCriteria.php

Spacing +1 added lines, -1 removed lines

@@ -37,6 +37,6 @@
      */
     public function apply($model, PrettusRepositoryInterface $repository)
     {
-        return DB::table($model->getModel()->getTable())->select('*', DB::raw('count('.$this->field.') as total_count'))->groupBy($this->field);
+        return DB::table($model->getModel()->getTable())->select('*', DB::raw('count(' . $this->field . ') as total_count'))->groupBy($this->field);
     }
 }