FindUserAction::byEverything() - Code Metrics - Inspection of "add refresh user endpoint" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 769d17...6fd8a2 )

by Mahmoud

created 2016-08-10 10:33 UTC

FindUserAction::byEverything() A

↳ Parent: FindUserAction

Complexity

Conditions	4
Paths	4

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	12
rs	9.2
cc	4
eloc	8
nc	4
nop	3

<?php

namespace App\Containers\User\Actions;

use App\Containers\User\Exceptions\UserNotFoundException;
use App\Containers\User\Services\FindUserService;
use App\Port\Action\Abstracts\Action;
use Exception;
use Illuminate\Support\Facades\Auth;

/**
 * Class FindUserAction.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class FindUserAction extends Action
{

    /**
     * @var  \App\Containers\User\Services\FindUserService
     */
    private $findUserService;

    /**
     * FindUserByIdAction constructor.
     *
     * @param \App\Containers\User\Services\FindUserService $findUserService
     */
    public function __construct(
        FindUserService $findUserService
    ) {
        $this->findUserService = $findUserService;
    }


    /**
     * @param $id
     *
     * @return  mixed
     */
    public function run($id)
    {
        try {
            $user = $this->findUserService->byId($id);
        } catch (Exception $e) {
            throw new UserNotFoundException;
        }

        return $user;
    }

    /**
     * @param $userId
     * @param $visitorId
     * @param $token
     *
     * @return  mixed
     */
    public function byEverything($userId, $visitorId, $token)
    {
        if($userId){
            $user = $this->findUserService->byId($userId);
        }else if($token){
            $user = Auth::user();
        }else if($visitorId){
            $user = $this->findUserService->byVisitorId($visitorId);
        }

        return $user;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }



}


1			<?php
2
3			namespace App\Containers\User\Actions;
4
5			use App\Containers\User\Exceptions\UserNotFoundException;
6			use App\Containers\User\Services\FindUserService;
7			use App\Port\Action\Abstracts\Action;
8			use Exception;
9			use Illuminate\Support\Facades\Auth;
10
11			/**
12			* Class FindUserAction.
13			*
14			* @author Mahmoud Zalt <[email protected]>
15			*/
16			class FindUserAction extends Action
17			{
18
19			/**
20			* @var \App\Containers\User\Services\FindUserService
21			*/
22			private $findUserService;
23
24			/**
25			* FindUserByIdAction constructor.
26			*
27			* @param \App\Containers\User\Services\FindUserService $findUserService
28			*/
29			public function __construct(
30			FindUserService $findUserService
31			) {
32			$this->findUserService = $findUserService;
33			}
34
35
36			/**
37			* @param $id
38			*
39			* @return mixed
40			*/
41			public function run($id)
42			{
43			try {
44			$user = $this->findUserService->byId($id);
45			} catch (Exception $e) {
46			throw new UserNotFoundException;
47			}
48
49			return $user;
50			}
51
52			/**
53			* @param $userId
54			* @param $visitorId
55			* @param $token
56			*
57			* @return mixed
58			*/
59			public function byEverything($userId, $visitorId, $token)
60			{
61			if($userId){
62			$user = $this->findUserService->byId($userId);
63			}else if($token){
64			$user = Auth::user();
65			}else if($visitorId){
66			$user = $this->findUserService->byVisitorId($visitorId);
67			}
68
69			return $user;
			0 ignored issues – show Bug introduced 2016-08-10 10:37 UTC by Report Bug Copy Issue Report The variable `$user` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
70			}
71
72
73
74			}
75

Porto-SAP / Hello-API

Push — master ( 769d17...6fd8a2 )

FindUserAction::byEverything() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like