ConfigsLoaderTrait::loadConfigs() - Code Metrics - Inspection of "refactor components autoloaders" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60840d...857394 )

by Mahmoud

created 2017-02-05 21:11 UTC

ConfigsLoaderTrait::loadConfigs() A

↳ Parent: ConfigsLoaderTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	3
nop	1

<?php

namespace App\Port\Loader\Loaders;

use App;
use App\Port\Foundation\Portals\Facade\PortButler;
use DB;
use File;

/**
 * Class ConfigsLoaderTrait.
 *
 * @author  Mahmoud Zalt <[email protected]>
 */
trait ConfigsLoaderTrait
{

    /**
     * runConfigsAutoLoader
     */
    public function runConfigsAutoLoader()
    {
        $this->loadConfigsFromPort();
        $this->loadConfigsFromContainers();
    }

    /**
     * loadConfigsFromContainers
     */
    private function loadConfigsFromContainers()
    {
        foreach (PortButler::getContainersNames() as $containerName) {
            $this->loadConfigs(base_path('app/Containers/' . $containerName . '/Configs'));
        }
    }

    /**
     * loadConfigsFromPort
     */
    private function loadConfigsFromPort()
    {
        // $this->portConfigsDirectories is defined on the main service provider class
        foreach ($this->portConfigsDirectories as $portConfigsDirectory) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $this->loadConfigs(base_path('app/Port/') . $portConfigsDirectory);
        }
    }

    /**
     * @param $directory
     */
    private function loadConfigs($directory)
    {
        if (File::isDirectory($directory)) {

            $files = File::allFiles($directory);

            foreach ($files as $file) {
                // build the key from the file name (just remove the .php extension from the file name)
                $fileNameOnly = str_replace('.php', '', $file->getFilename());

                // merge the config file
                $this->mergeConfigFrom($file->getPathname(), $fileNameOnly);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }
}


1			<?php
2
3			namespace App\Port\Loader\Loaders;
4
5			use App;
6			use App\Port\Foundation\Portals\Facade\PortButler;
7			use DB;
8			use File;
9
10			/**
11			* Class ConfigsLoaderTrait.
12			*
13			* @author Mahmoud Zalt <[email protected]>
14			*/
15			trait ConfigsLoaderTrait
16			{
17
18			/**
19			* runConfigsAutoLoader
20			*/
21			public function runConfigsAutoLoader()
22			{
23			$this->loadConfigsFromPort();
24			$this->loadConfigsFromContainers();
25			}
26
27			/**
28			* loadConfigsFromContainers
29			*/
30			private function loadConfigsFromContainers()
31			{
32			foreach (PortButler::getContainersNames() as $containerName) {
33			$this->loadConfigs(base_path('app/Containers/' . $containerName . '/Configs'));
34			}
35			}
36
37			/**
38			* loadConfigsFromPort
39			*/
40			private function loadConfigsFromPort()
41			{
42			// $this->portConfigsDirectories is defined on the main service provider class
43			foreach ($this->portConfigsDirectories as $portConfigsDirectory) {
			0 ignored issues – show Bug introduced 2017-02-05 21:14 UTC by Report Bug Copy Issue Report The property `portConfigsDirectories` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			$this->loadConfigs(base_path('app/Port/') . $portConfigsDirectory);
45			}
46			}
47
48			/**
49			* @param $directory
50			*/
51			private function loadConfigs($directory)
52			{
53			if (File::isDirectory($directory)) {
54
55			$files = File::allFiles($directory);
56
57			foreach ($files as $file) {
58			// build the key from the file name (just remove the .php extension from the file name)
59			$fileNameOnly = str_replace('.php', '', $file->getFilename());
60
61			// merge the config file
62			$this->mergeConfigFrom($file->getPathname(), $fileNameOnly);
			0 ignored issues – show Bug introduced 2016-10-26 20:33 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
63			}
64			}
65			}
66			}
67

Porto-SAP / Hello-API

Push — master ( 60840d...857394 )

ConfigsLoaderTrait::loadConfigs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like