ViewsLoaderTrait - Code Metrics - Inspection of "refactor components autoloaders" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 60840d...857394 )

by Mahmoud

created 2017-02-05 21:11 UTC

ViewsLoaderTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	23.91 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	1
dl	11
loc	46
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	runViewsAutoLoader()	0	5	1
A	loadViewsFromContainers()	11	11	3
A	loadViews()	0	4	1
A	loadViewsFromPort()	0	7	1

How to fix Duplicated Code

<?php

namespace App\Port\Loader\Loaders;

use App;
use App\Port\Foundation\Portals\Facade\PortButler;
use DB;
use File;
use Illuminate\Support\Facades\View;
use Log;

/**
 * Class ViewsLoaderTrait.
 *
 * @author  Mahmoud Zalt <[email protected]>
 */
trait ViewsLoaderTrait
{

    /**
     * runViewsAutoLoader
     */
    public function runViewsAutoLoader()
    {
        $this->loadViewsFromPort();
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        $this->loadViewsFromContainers();
    }

    /**
     * loadViewsFromContainers
     */
    private function loadViewsFromContainers()

    {
        foreach (PortButler::getContainersNames() as $containerName) {

            $containerViewDirectory = base_path('app/Containers/' . $containerName . '/UI/WEB/Views/');

            if (File::isDirectory($containerViewDirectory)) {
                $this->loadViews($containerViewDirectory);
            }
        }
    }

    /**
     * @param $directory
     */
    private function loadViews($directory)
    {
        View::addLocation($directory);
    }

    /**
     * loadViewsFromPort
     */
    private function loadViewsFromPort()
    {
        // TODO: Implement this function when needed

        // defined on the Main Service Provider
        $this->portViewsDirectories;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1		<?php
2
3		namespace App\Port\Loader\Loaders;
4
5		use App;
6		use App\Port\Foundation\Portals\Facade\PortButler;
7		use DB;
8		use File;
9		use Illuminate\Support\Facades\View;
10		use Log;
11
12		/**
13		* Class ViewsLoaderTrait.
14		*
15		* @author Mahmoud Zalt <[email protected]>
16		*/
17		trait ViewsLoaderTrait
18		{
19
20		/**
21		* runViewsAutoLoader
22		*/
23		public function runViewsAutoLoader()
24		{
25		$this->loadViewsFromPort();
		0 ignored issues – show Unused Code introduced 2017-02-05 21:14 UTC by Report Bug Copy Issue Report The call to the method `App\Port\Loader\Loaders\...it::loadViewsFromPort()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
26		$this->loadViewsFromContainers();
27		}
28
29		/**
30		* loadViewsFromContainers
31		*/
32	View Code Duplication	private function loadViewsFromContainers()
		0 ignored issues – show Duplication introduced 2016-12-01 20:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
33		{
34		foreach (PortButler::getContainersNames() as $containerName) {
35
36		$containerViewDirectory = base_path('app/Containers/' . $containerName . '/UI/WEB/Views/');
37
38		if (File::isDirectory($containerViewDirectory)) {
39		$this->loadViews($containerViewDirectory);
40		}
41		}
42		}
43
44		/**
45		* @param $directory
46		*/
47		private function loadViews($directory)
48		{
49		View::addLocation($directory);
50		}
51
52		/**
53		* loadViewsFromPort
54		*/
55		private function loadViewsFromPort()
56		{
57		// TODO: Implement this function when needed
58
59		// defined on the Main Service Provider
60		$this->portViewsDirectories;
		0 ignored issues – show Bug introduced 2017-02-05 21:14 UTC by Report Bug Copy Issue Report The property `portViewsDirectories` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
61		}
62		}
63

Porto-SAP / Hello-API

Push — master ( 60840d...857394 )

ViewsLoaderTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like