DeleteContainersCommand::handle() - Code Metrics - Inspection of "add default containers on startup" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9096b6...7d3c95 )

by Mahmoud

created 2016-11-29 19:11 UTC

DeleteContainersCommand::handle() B

↳ Parent: DeleteContainersCommand

Complexity

Conditions	4
Paths	5

Size

Total Lines	35
Code Lines	16

Duplication

Lines	35
Ratio	100 %

Importance

Changes

Metric	Value
dl	35
loc	35
rs	8.5806
c	0
b	0
f	0
cc	4
eloc	16
nc	5
nop	0

<?php

namespace App\Port\Command\Commands;

use App\Port\Console\Abstracts\ConsoleCommand;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

/**
 * Class DeleteContainersCommand
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class DeleteContainersCommand extends ConsoleCommand

{

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = "containers:remove {container-names*}"; // {--skip-update=false}

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = "select existing container to download";

    /**
     * Create a new command instance.
     *
     * @return void

     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $ContainersPath = "app/Containers";

        foreach ($this->argument("container-names") as $repoName) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $repoName = ucfirst(strtolower($repoName));

            // TODO: find a way to validate the repo!
            $process = new Process("rm -rf " . $ContainersPath . '/' .$repoName);
            $process->run();

            if (!$process->isSuccessful()) {
                throw new ProcessFailedException($process);
            }

            echo "Container " . $repoName . " deleted successfully.\n";
        }

        // TODO: add skip update option

//        if (!$this->option('skip-update')) {


            echo "Running 'Composer Update'..\n";
            $process = new Process("composer update");
            $process->run();

            if (!$process->isSuccessful()) {
                throw new ProcessFailedException($process);
            }

            echo $process->getOutput();
//        }

        echo "Congratulation :)\n";
    }
}


1		<?php
2
3		namespace App\Port\Command\Commands;
4
5		use App\Port\Console\Abstracts\ConsoleCommand;
6		use Symfony\Component\Process\Exception\ProcessFailedException;
7		use Symfony\Component\Process\Process;
8
9		/**
10		* Class DeleteContainersCommand
11		*
12		* @author Mahmoud Zalt <[email protected]>
13		*/
14	View Code Duplication	class DeleteContainersCommand extends ConsoleCommand
		0 ignored issues – show Duplication introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15		{
16
17		/**
18		* The name and signature of the console command.
19		*
20		* @var string
21		*/
22		protected $signature = "containers:remove {container-names*}"; // {--skip-update=false}
23
24		/**
25		* The console command description.
26		*
27		* @var string
28		*/
29		protected $description = "select existing container to download";
30
31		/**
32		* Create a new command instance.
33		*
34		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
35		*/
36		public function __construct()
37		{
38		parent::__construct();
39		}
40
41		/**
42		* Execute the console command.
43		*
44		* @return mixed
45		*/
46		public function handle()
47		{
48		$ContainersPath = "app/Containers";
49
50		foreach ($this->argument("container-names") as $repoName) {
		0 ignored issues – show Bug introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report The expression `$this->argument('container-names')` of type `string\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
51		$repoName = ucfirst(strtolower($repoName));
52
53		// TODO: find a way to validate the repo!
54		$process = new Process("rm -rf " . $ContainersPath . '/' .$repoName);
55		$process->run();
56
57		if (!$process->isSuccessful()) {
58		throw new ProcessFailedException($process);
59		}
60
61		echo "Container " . $repoName . " deleted successfully.\n";
62		}
63
64		// TODO: add skip update option
65
66		// if (!$this->option('skip-update')) {
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-29 19:53 UTC by Report Bug Copy Issue Report `72%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
67
68		echo "Running 'Composer Update'..\n";
69		$process = new Process("composer update");
70		$process->run();
71
72		if (!$process->isSuccessful()) {
73		throw new ProcessFailedException($process);
74		}
75
76		echo $process->getOutput();
77		// }
78
79		echo "Congratulation :)\n";
80		}
81		}
82

Porto-SAP / Hello-API

Push — master ( 9096b6...7d3c95 )

DeleteContainersCommand::handle() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like