SendConfirmationEmailTask - Code Metrics - Inspection of "rename Services to Tasks (to avoid conflict with t..." - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d8e2a0...679457 )

by Mahmoud

created 2016-08-17 16:03 UTC

SendConfirmationEmailTask A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	1
cbo	1
dl	0
loc	32
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	run()	0	11	1

<?php

namespace App\Containers\Email\Tasks;

use App\Containers\Email\Mails\ConfirmEmail;
use App\Containers\User\Models\User;
use App\Port\Task\Abstracts\Task;

/**
 * Class SendConfirmationEmailTask.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class SendConfirmationEmailTask extends Task
{


    /**
     * SendConfirmationEmailTask constructor.
     *
     * @param \App\Containers\Email\Mails\ConfirmEmail $confirmEmail
     */
    public function __construct(ConfirmEmail $confirmEmail)
    {
        $this->email = $confirmEmail;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param \App\Containers\User\Models\User $user
     * @param                                  $confirmationUrl
     *
     * @return  bool
     */
    public function run(User $user, $confirmationUrl)
    {
        $this->email->setEmail($user->email);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->email->setName($user->name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $result = $this->email->send([
            'name' => $user->name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'url'  => $confirmationUrl,
        ]);

        return $result;
    }
}


1			<?php
2
3			namespace App\Containers\Email\Tasks;
4
5			use App\Containers\Email\Mails\ConfirmEmail;
6			use App\Containers\User\Models\User;
7			use App\Port\Task\Abstracts\Task;
8
9			/**
10			* Class SendConfirmationEmailTask.
11			*
12			* @author Mahmoud Zalt <[email protected]>
13			*/
14			class SendConfirmationEmailTask extends Task
15			{
16
17
18			/**
19			* SendConfirmationEmailTask constructor.
20			*
21			* @param \App\Containers\Email\Mails\ConfirmEmail $confirmEmail
22			*/
23			public function __construct(ConfirmEmail $confirmEmail)
24			{
25			$this->email = $confirmEmail;
			0 ignored issues – show Bug introduced 2016-07-18 05:36 UTC by Report Bug Copy Issue Report The property `email` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
26			}
27
28			/**
29			* @param \App\Containers\User\Models\User $user
30			* @param $confirmationUrl
31			*
32			* @return bool
33			*/
34			public function run(User $user, $confirmationUrl)
35			{
36			$this->email->setEmail($user->email);
			0 ignored issues – show Documentation introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<App\Containers\User\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37			$this->email->setName($user->name);
			0 ignored issues – show Documentation introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Containers\User\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			$result = $this->email->send([
39			'name' => $user->name,
			0 ignored issues – show Documentation introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<App\Containers\User\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			'url' => $confirmationUrl,
41			]);
42
43			return $result;
44			}
45			}
46

Porto-SAP / Hello-API

Push — master ( d8e2a0...679457 )

SendConfirmationEmailTask A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like