Porto-SAP / Hello-API

app/Port/Tests/PHPUnit/Traits/TestingTrait.php

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

Doc Comments +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
     public $loggedInTestingUser;
 
     /**
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param string $verb
      * @param array  $data
      * @param bool   $protected
@@ -133,7 +133,7 @@ 
     }
 
     /**
-     * @return  App\Containers\User\Models\User|mixed
+     * @return  User
      */
     public function getLoggedInTestingAdmin()
     {
@@ -171,7 +171,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingUser($userDetails = null)
     {
@@ -202,7 +202,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingAdmin($userDetails = null)
     {
@@ -218,7 +218,7 @@ 
      *
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingDeveloper($userDetails = null)
     {
@@ -233,7 +233,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)

app/Containers/Authorization/Data/Migrations/2016_12_29_201047_create_permission_tables.php

Spacing +5 added lines, -5 removed lines

@@ -14,7 +14,7 @@ 
     {
         $config = config('laravel-permission.table_names');
 
-        Schema::create($config['roles'], function (Blueprint $table) {
+        Schema::create($config['roles'], function(Blueprint $table) {
             $table->increments('id');
             $table->string('name')->unique();
             $table->string('display_name')->nullable();
@@ -22,7 +22,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create($config['permissions'], function (Blueprint $table) {
+        Schema::create($config['permissions'], function(Blueprint $table) {
             $table->increments('id');
             $table->string('name')->unique();
             $table->string('display_name')->nullable();
@@ -30,7 +30,7 @@ 
             $table->timestamps();
         });
 
-        Schema::create($config['user_has_permissions'], function (Blueprint $table) use ($config) {
+        Schema::create($config['user_has_permissions'], function(Blueprint $table) use ($config) {
             $table->integer('user_id')->unsigned();
             $table->integer('permission_id')->unsigned();
 
@@ -47,7 +47,7 @@ 
             $table->primary(['user_id', 'permission_id']);
         });
 
-        Schema::create($config['user_has_roles'], function (Blueprint $table) use ($config) {
+        Schema::create($config['user_has_roles'], function(Blueprint $table) use ($config) {
             $table->integer('role_id')->unsigned();
             $table->integer('user_id')->unsigned();
 
@@ -64,7 +64,7 @@ 
             $table->primary(['role_id', 'user_id']);
         });
 
-        Schema::create($config['role_has_permissions'], function (Blueprint $table) use ($config) {
+        Schema::create($config['role_has_permissions'], function(Blueprint $table) use ($config) {
             $table->integer('permission_id')->unsigned();
             $table->integer('role_id')->unsigned();
 

app/Containers/Authorization/UI/API/Tests/Functional/FindPermissionByNameTest.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace App\Containers\Order\UI\API\Tests\Functional;
 
 use App\Containers\Order\Models\Order;
-use App\Containers\Invoice\Models\Invoice;
-use App\Containers\User\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
-use Vinkla\Hashids\Facades\Hashids;
 
 /**
  * Class FindPermissionByNameTest.

app/Containers/Authorization/UI/API/Tests/Functional/FindRoleByNameTest.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace App\Containers\Order\UI\API\Tests\Functional;
 
 use App\Containers\Order\Models\Order;
-use App\Containers\Invoice\Models\Invoice;
-use App\Containers\User\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
-use Vinkla\Hashids\Facades\Hashids;
 
 /**
  * Class FindRoleByNameTest.

app/Containers/Authorization/UI/API/Tests/Functional/ListPermissionsTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Containers\Authorization\UI\API\Tests\Functional;
 
-use App\Containers\Authorization\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
 
 /**

app/Containers/User/Actions/CreateUserAction.php

Indentation +1 added lines, -1 removed lines

@@ -67,7 +67,7 @@
         // be default give all users the client role (normal user)
         $this->assignRoleTask->run($user, ['client']);
 
-       //  add Client as role for normal users
+        //  add Client as role for normal users
         $this->fireUserCreatedEventTask->run($user);
 
         return $user;

app/Containers/Authorization/Actions/AssignRoleAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -21,7 +21,7 @@
     /**
      * GetAdminRoleAction constructor.
      *
-     * @param \App\Containers\Authorization\Data\Repositories\AssignRoleTask $assignRoleTask
+     * @param AssignRoleTask $assignRoleTask
      */
     public function __construct(AssignRoleTask $assignRoleTask)
     {

app/Containers/Authorization/UI/API/Tests/Functional/AttachPermissionsToRoleTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App\Containers\Authorization\Models\Permission;
 use App\Containers\Authorization\Models\Role;
-use App\Containers\User\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
 
 /**

app/Containers/Authorization/Tasks/AssignRoleTask.php

Spacing +2 added lines, -2 removed lines

@@ -45,7 +45,7 @@ 
      */
     public function run($user, $roles)
     {
-        if(!$user instanceof User){
+        if (!$user instanceof User) {
             $user = $this->findUserByIdTask->run($user);
         }
 
@@ -54,7 +54,7 @@ 
                 $this->assignRole($user, $role);
             }
 
-        }else{
+        } else {
             $this->assignRole($user, $roles);
         }
 

Braces +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
                 $this->assignRole($user, $role);
             }
 
-        }else{
+        } else{
             $this->assignRole($user, $roles);
         }