Porto-SAP / Hello-API

app/Port/Test/PHPUnit/Abstracts/TestCase.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use App\Port\Test\PHPUnit\Traits\CustomTestsHelpersTrait;
 use App\Port\Test\PHPUnit\Traits\GeneralTestsHelpersTrait;
 use App\Port\Test\PHPUnit\Traits\TestCaseTrait;
-use App\Port\Test\PHPUnit\Traits\TestingTrait;
 use App\Port\Test\PHPUnit\Traits\TestingUserTrait;
 use Faker\Generator;
 use Illuminate\Contracts\Console\Kernel as LaravelKernel;

app/Port/Test/PHPUnit/Traits/GeneralTestsHelpersTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
      *
      * Example: you give it ('users/{id}/stores', 100) it returns 'users/100/stores'
      *
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param        $id
      * @param bool   $skipEncoding
      * @param string $replace
@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Port\Test\PHPUnit\Traits;
 
 use App;
-use Artisan;
 use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Http\Response;
 use Illuminate\Http\UploadedFile;

app/Port/Test/PHPUnit/Traits/TestCaseTrait.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App;
 use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 
 /**
  * Class TestCaseTrait

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Port/Test/PHPUnit/Traits/TestingUserTrait.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use App;
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
 use App\Containers\User\Models\User;
-use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Support\Facades\Hash;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
     public function createTestingUser($access = null, $userDetails = null)
     {
         // if no user detail provided, use the default details.
-        $userDetails = $userDetails ? : [
+        $userDetails = $userDetails ?: [
             'name'     => 'Testing User',
             'email'    => $this->faker->email,
             'password' => 'testing-pass',
@@ -112,7 +112,7 @@ 
         ]);
 
         // assign roles and permissions
-        $user = $this->setupTestingUserAccess($user, $access ? : (isset($this->access) ? $this->access : null));
+        $user = $this->setupTestingUserAccess($user, $access ?: (isset($this->access) ? $this->access : null));
 
         // log the user in
         $user = App::make(ApiLoginThisUserObjectTask::class)->run($user);

app/Port/HashId/Traits/HashIdTrait.php

Spacing +3 added lines, -4 removed lines

@@ -29,7 +29,7 @@ 
     public function runEndpointsHashedIdsDecoder()
     {
         if (Config::get('hello.hash-id')) {
-            Route::bind('id', function ($id, $route) {
+            Route::bind('id', function($id, $route) {
                 // skip decoding some endpoints
                 if (!in_array($route->uri(), $this->skippedEndpoints)) {
 
@@ -58,7 +58,7 @@ 
     {
         // hash the ID only if hash-id enabled in the config
         if (Config::get('hello.hash-id')) {
-            return $this->encoder(($key) ? : $this->getKey());
+            return $this->encoder(($key) ?: $this->getKey());
         }
 
         return $this->getKey();
@@ -85,8 +85,7 @@ 
 
                 if (Config::get('hello.hash-id')) {
                     $requestData[$id] = is_array($requestData[$id]) ?
-                        $this->decodeThisArrayOfIds($requestData[$id]) :
-                        $this->decodeThisId($requestData[$id]);
+                        $this->decodeThisArrayOfIds($requestData[$id]) : $this->decodeThisId($requestData[$id]);
                 }
 
             } // do nothing if the input is incorrect, because what if it's not required!

app/Containers/Authorization/Actions/AttachPermissionsToRoleAction.php

Spacing +2 added lines, -2 removed lines

@@ -59,10 +59,10 @@
         $permissions = [];
 
         if (is_array($permissionsIds)) {
-            foreach ($permissionsIds as $permissionId){
+            foreach ($permissionsIds as $permissionId) {
                 $permissions[] = $this->getPermissionTask->run($permissionId);
             }
-        }else{
+        } else {
             $permissions[] = $this->getPermissionTask->run($permissionsIds);
         }
 

Braces +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
             foreach ($permissionsIds as $permissionId){
                 $permissions[] = $this->getPermissionTask->run($permissionId);
             }
-        }else{
+        } else{
             $permissions[] = $this->getPermissionTask->run($permissionsIds);
         }
 

app/Containers/Authorization/Data/Factories/PermissionFactory.php

Spacing +1 added lines, -1 removed lines

@@ -3,7 +3,7 @@
 // User
 use App\Containers\Authorization\Models\Permission;
 
-$factory->define(Permission::class, function (Faker\Generator $faker) {
+$factory->define(Permission::class, function(Faker\Generator $faker) {
 
     return [
         'name' => $faker->slug,

app/Containers/Authorization/Actions/RevokeUserFromRoleAction.php

Doc Comments +1 added lines, -1 removed lines

@@ -50,7 +50,7 @@
     }
 
     /**
-     * @param User|integer $userId
+     * @param User|integer $user
      * @param integer|array $rolesIds
      *
      * @return  \App\Containers\User\Models\User