UserPolicy - Code Metrics - Inspection of "move policies to the API directory" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 707115...75abcf )

by Mahmoud

created 2016-07-18 16:54 UTC

UserPolicy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
c	1
b	0
f	0
lcom	0
cbo	2
dl	0
loc	32
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	5	2
A	delete()	0	5	2

<?php

namespace App\Containers\User\UI\API\Policies;

use App\Port\Policy\Abstracts\Policy;
use Illuminate\Auth\Access\HandlesAuthorization;
use App\Containers\User\Models\User;

/**
 * Class UserPolicy.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class UserPolicy extends Policy
{
    use HandlesAuthorization;

    /**
     * Determine if the user is updating himself and not another user.
     *
     * @param \App\Containers\User\Models\User $user
     * @param                                $inputUserId
     *
     * @return bool
     */
    public function update(User $user, $inputUserId)
    {
        // authorize only if a user is updating it's own records
        return ($user->id == $inputUserId) ? true : false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Determine if the user is deleting himself and not another user.
     *
     * @param \App\Containers\User\Models\User $user
     * @param                                $inputUserId
     *
     * @return bool
     */
    public function delete(User $user, $inputUserId)
    {
        // authorize only if a user is deleting it's own records
        return ($user->id == $inputUserId) ? true : false;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace App\Containers\User\UI\API\Policies;
4
5			use App\Port\Policy\Abstracts\Policy;
6			use Illuminate\Auth\Access\HandlesAuthorization;
7			use App\Containers\User\Models\User;
8
9			/**
10			* Class UserPolicy.
11			*
12			* @author Mahmoud Zalt <[email protected]>
13			*/
14			class UserPolicy extends Policy
15			{
16			use HandlesAuthorization;
17
18			/**
19			* Determine if the user is updating himself and not another user.
20			*
21			* @param \App\Containers\User\Models\User $user
22			* @param $inputUserId
23			*
24			* @return bool
25			*/
26			public function update(User $user, $inputUserId)
27			{
28			// authorize only if a user is updating it's own records
29			return ($user->id == $inputUserId) ? true : false;
			0 ignored issues – show Documentation introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Containers\User\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
30			}
31
32			/**
33			* Determine if the user is deleting himself and not another user.
34			*
35			* @param \App\Containers\User\Models\User $user
36			* @param $inputUserId
37			*
38			* @return bool
39			*/
40			public function delete(User $user, $inputUserId)
41			{
42			// authorize only if a user is deleting it's own records
43			return ($user->id == $inputUserId) ? true : false;
			0 ignored issues – show Documentation introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<App\Containers\User\Models\User>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
44			}
45			}
46

Porto-SAP / Hello-API

Push — master ( 707115...75abcf )

UserPolicy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like