App\Containers\User\Actions\CreateVisitorUserAction

Complexity

Total Complexity

3

Size/Duplication

Total Lines	50
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	run()	0	10	2

<?php

namespace App\Containers\User\Actions;

use App\Containers\User\Tasks\CreateUserTask;
use App\Containers\User\Tasks\FindUserTask;
use App\Port\Action\Abstracts\Action;

/**
 * Class CreateVisitorUserAction.
 *
 * @author Mahmoud Zalt <mahmoud@zalt.me>
 */
class CreateVisitorUserAction extends Action
{

    /**
     * @var  \App\Containers\User\Actions\CreateUserTask
     */
    private $createUserTask;

    /**
     * @var  \App\Containers\User\Tasks\FindUserTask
     */
    private $findUserTask;

    /**
     * CreateUserAction constructor.
     *
     * @param \App\Containers\User\Tasks\CreateUserTask $createUserTask
     * @param \App\Containers\User\Tasks\FindUserTask   $findUserTask
     */
    public function __construct(CreateUserTask $createUserTask, FindUserTask $findUserTask)
    {
        $this->createUserTask = $createUserTask;

It seems like $createUserTask of type object<App\Containers\User\Tasks\CreateUserTask> is incompatible with the declared type object<App\Containers\User\Actions\CreateUserTask> of property $createUserTask.

        $this->findUserTask = $findUserTask;
    }

    /**
     * This is to be used only by a Middleware, it is a way to store records about the user
     * even before he registers. Very helpful for Mobile apps that doesn't require a user to
     * register and login before using the app.
     * Then when the user decided to register (to use some extra features) the `UpdateVisitorUserAction`
     * Action will be used to update the already created user (user will be determined by his Device ID).
     *
     * @param            $visitorId
     * @param null       $platform
     * @param null       $device
     * @param bool|false $login

There is no parameter named $login. Was it maybe removed?

     *
     * @return  mixed
     */
    public function run($visitorId, $device = null, $platform = null)
    {
        $user = $this->findUserTask->byVisitorId($visitorId);

        if(!$user){
            $user = $this->createUserTask->byVisitor($visitorId, $device, $platform);
        }

        return $user;
    }
}