ChargeWithPaypalTask::run() - Code Metrics - Inspection of "get all containers back inside the Hello API repo,..." - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e93f60...2f787f )

by Mahmoud

created 2016-12-01 18:15 UTC

ChargeWithPaypalTask::run() B

↳ Parent: ChargeWithPaypalTask

Complexity

Conditions	3
Paths	3

Size

Total Lines	87
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	87
rs	8.6296
c	0
b	0
f	0
cc	3
eloc	56
nc	3
nop	3

How to fix Long Method

<?php

namespace App\Containers\Paypal\Tasks;

use Anouar\Paypalpayment\PaypalPayment;
use App\Containers\Payment\Contracts\Chargeable;
use App\Containers\Paypal\Exceptions\PaypalApiErrorException;
use App\Containers\User\Models\User;
use App\Port\Task\Abstracts\Task;
use Exception;
use Illuminate\Support\Facades\Config;

/**
 * Class ChargeWithPaypalTask.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class ChargeWithPaypalTask extends Task implements Chargeable
{

    /**
     * @var  \Anouar\Paypalpayment\PaypalPayment
     */
    private $paypalPayment;

    /**
     * ChargeWithPaypalTask constructor.
     *
     * @param \Anouar\Paypalpayment\PaypalPayment $paypalPayment
     */
    public function __construct(Paypalpayment $paypalPayment)
    {
        $this->paypalPayment = $paypalPayment;

        $this->paypalApi = $paypalPayment->apiContext(
class MyClass { }

$x = new MyClass();
$x->foo = true;
            Config::get('paypal_payment.Account.ClientId'),
            Config::get('paypal_payment.Account.ClientSecret')
        );
    }

    /**
     * @param \App\Containers\User\Models\User $user
     * @param                                  $amount
     * @param string                           $currency
     *
     * @return  array|null
     */
    public function run(User $user, $amount, $currency = 'USD')

    {

        // TODO:
        // this is code sample from the package readme.
        // this does not seem to be compatible with paypal
        // I need to remove this package (Paypalpayment) and replace with something else
        // was checking the Payum laravel package seems compatible with Paypal Express Checkout

        $card = $this->paypalPayment->creditCard();
        $card->setType("visa")
            ->setNumber("4758411877817150")
            ->setExpireMonth("05")
            ->setExpireYear("2019")
            ->setCvv2("456")
            ->setFirstName("Joe")
            ->setLastName("Shopper");

        $fi = $this->paypalPayment->fundingInstrument();
        $fi->setCreditCard($card);

        $payer = $this->paypalPayment->payer();
        $payer->setPaymentMethod("credit_card")
            ->setFundingInstruments(array($fi));

        $item1 = $this->paypalPayment->item();
        $item1->setName('Ground Coffee 40 oz')
            ->setDescription('Ground Coffee 40 oz')
            ->setCurrency('USD')
            ->setQuantity(1)
            ->setTax(0.3)
            ->setPrice(7.50);

        $item2 = $this->paypalPayment->item();
        $item2->setName('Granola bars')
            ->setDescription('Granola Bars with Peanuts')
            ->setCurrency('USD')
            ->setQuantity(5)
            ->setTax(0.2)
            ->setPrice(2);

        $itemList = $this->paypalPayment->itemList();
        $itemList->setItems(array($item1, $item2));

        $details = $this->paypalPayment->details();
        $details->setShipping("1.2")
            ->setTax("1.3")
            //total of items prices
            ->setSubtotal("17.5");

        //Payment Amount
        $amount = $this->paypalPayment->amount();
        $amount->setCurrency("USD")
            // the total is $17.8 = (16 + 0.6) * 1 ( of quantity) + 1.2 ( of Shipping).
            ->setTotal("20")
            ->setDetails($details);

        $transaction = $this->paypalPayment->transaction();
        $transaction->setAmount($amount)
            ->setItemList($itemList)
            ->setDescription("Payment description")
            ->setInvoiceNumber(uniqid());

        $payment = $this->paypalPayment->payment();

        $payment->setIntent("sale")
            ->setPayer($payer)
            ->setTransactions(array($transaction));

        try {

            $response = $payment->create($this->paypalApi);

        } catch (Exception $e) {
            throw (new PaypalApiErrorException('Paypal API error (payment)'))->debug($e->getMessage(), true);
        }

        if ($response['state'] != 'approved') {
            throw new PaypalApiErrorException('Paypal response status not succeeded (payment)');
        }

        // this data will be stored on the pivot table (user credits)
        return [
            'payment_method' => 'paypal',
            'description'    => $response['id'], // Pay ID
        ];
    }

    /**
     * @param \App\Containers\User\Models\User $user
     * @param                                  $amount
     * @param string                           $currency
     *
     * @return  array|null
     */
    public function charge(User $user, $amount, $currency = 'USD')
    {
        return $this->run($user, $amount, $currency);
    }

}


1			<?php
2
3			namespace App\Containers\Paypal\Tasks;
4
5			use Anouar\Paypalpayment\PaypalPayment;
6			use App\Containers\Payment\Contracts\Chargeable;
7			use App\Containers\Paypal\Exceptions\PaypalApiErrorException;
8			use App\Containers\User\Models\User;
9			use App\Port\Task\Abstracts\Task;
10			use Exception;
11			use Illuminate\Support\Facades\Config;
12
13			/**
14			* Class ChargeWithPaypalTask.
15			*
16			* @author Mahmoud Zalt <[email protected]>
17			*/
18			class ChargeWithPaypalTask extends Task implements Chargeable
19			{
20
21			/**
22			* @var \Anouar\Paypalpayment\PaypalPayment
23			*/
24			private $paypalPayment;
25
26			/**
27			* ChargeWithPaypalTask constructor.
28			*
29			* @param \Anouar\Paypalpayment\PaypalPayment $paypalPayment
30			*/
31			public function __construct(Paypalpayment $paypalPayment)
32			{
33			$this->paypalPayment = $paypalPayment;
34
35			$this->paypalApi = $paypalPayment->apiContext(
			0 ignored issues – show Bug introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The property `paypalApi` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			Config::get('paypal_payment.Account.ClientId'),
37			Config::get('paypal_payment.Account.ClientSecret')
38			);
39			}
40
41			/**
42			* @param \App\Containers\User\Models\User $user
43			* @param $amount
44			* @param string $currency
45			*
46			* @return array\|null
47			*/
48			public function run(User $user, $amount, $currency = 'USD')
			0 ignored issues – show Unused Code introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The parameter `$user` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The parameter `$amount` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-07-16 04:08 UTC by Report Bug Copy Issue Report The parameter `$currency` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
49			{
50
51			// TODO:
52			// this is code sample from the package readme.
53			// this does not seem to be compatible with paypal
54			// I need to remove this package (Paypalpayment) and replace with something else
55			// was checking the Payum laravel package seems compatible with Paypal Express Checkout
56
57			$card = $this->paypalPayment->creditCard();
58			$card->setType("visa")
59			->setNumber("4758411877817150")
60			->setExpireMonth("05")
61			->setExpireYear("2019")
62			->setCvv2("456")
63			->setFirstName("Joe")
64			->setLastName("Shopper");
65
66			$fi = $this->paypalPayment->fundingInstrument();
67			$fi->setCreditCard($card);
68
69			$payer = $this->paypalPayment->payer();
70			$payer->setPaymentMethod("credit_card")
71			->setFundingInstruments(array($fi));
72
73			$item1 = $this->paypalPayment->item();
74			$item1->setName('Ground Coffee 40 oz')
75			->setDescription('Ground Coffee 40 oz')
76			->setCurrency('USD')
77			->setQuantity(1)
78			->setTax(0.3)
79			->setPrice(7.50);
80
81			$item2 = $this->paypalPayment->item();
82			$item2->setName('Granola bars')
83			->setDescription('Granola Bars with Peanuts')
84			->setCurrency('USD')
85			->setQuantity(5)
86			->setTax(0.2)
87			->setPrice(2);
88
89			$itemList = $this->paypalPayment->itemList();
90			$itemList->setItems(array($item1, $item2));
91
92			$details = $this->paypalPayment->details();
93			$details->setShipping("1.2")
94			->setTax("1.3")
95			//total of items prices
96			->setSubtotal("17.5");
97
98			//Payment Amount
99			$amount = $this->paypalPayment->amount();
100			$amount->setCurrency("USD")
101			// the total is $17.8 = (16 + 0.6) * 1 ( of quantity) + 1.2 ( of Shipping).
102			->setTotal("20")
103			->setDetails($details);
104
105			$transaction = $this->paypalPayment->transaction();
106			$transaction->setAmount($amount)
107			->setItemList($itemList)
108			->setDescription("Payment description")
109			->setInvoiceNumber(uniqid());
110
111			$payment = $this->paypalPayment->payment();
112
113			$payment->setIntent("sale")
114			->setPayer($payer)
115			->setTransactions(array($transaction));
116
117			try {
118
119			$response = $payment->create($this->paypalApi);
120
121			} catch (Exception $e) {
122			throw (new PaypalApiErrorException('Paypal API error (payment)'))->debug($e->getMessage(), true);
123			}
124
125			if ($response['state'] != 'approved') {
126			throw new PaypalApiErrorException('Paypal response status not succeeded (payment)');
127			}
128
129			// this data will be stored on the pivot table (user credits)
130			return [
131			'payment_method' => 'paypal',
132			'description' => $response['id'], // Pay ID
133			];
134			}
135
136			/**
137			* @param \App\Containers\User\Models\User $user
138			* @param $amount
139			* @param string $currency
140			*
141			* @return array\|null
142			*/
143			public function charge(User $user, $amount, $currency = 'USD')
144			{
145			return $this->run($user, $amount, $currency);
146			}
147
148			}
149

Porto-SAP / Hello-API

Push — master ( e93f60...2f787f )

ChargeWithPaypalTask::run() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like