ConfigsLoaderTrait::loadConfigs() - Code Metrics - Inspection of "refactor autoloading config files" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 390c77...fb089c )

by Mahmoud

created 2016-12-01 18:55 UTC

ConfigsLoaderTrait::loadConfigs() A

↳ Parent: ConfigsLoaderTrait

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	15
rs	9.4285
cc	3
eloc	6
nc	3
nop	1

<?php

namespace App\Port\Config\Loaders;

use App;
use App\Port\Butler\Portals\Facade\PortButler;
use DB;
use File;
use Log;

/**
 * Class ConfigsLoaderTrait.
 *
 * @author  Mahmoud Zalt <[email protected]>
 */
trait ConfigsLoaderTrait
{

    /**
     * Auto load Containers and Port config files into Laravel
     */
    public function autoLoadConfigFiles()
    {
        $this->autoLoadContainersConfigFiles();
        $this->autoLoadPortConfigFiles();
    }

    protected function autoLoadContainersConfigFiles()
    {
        foreach (PortButler::getContainersNames() as $containerName) {
            $this->loadConfigs(base_path('app/Containers/' . $containerName . '/Configs'));
        }
    }

    protected function autoLoadPortConfigFiles()
    {
        $this->loadConfigs(base_path('app/Port/Config/Configs'));
    }

    /**
     * @param $directory
     */
    private function loadConfigs($directory)
    {
        if (File::isDirectory($directory)) {

            $files = File::allFiles($directory);

            foreach ($files as $file) {
                // build the key from the file name (just remove the .php extension from the file name)
                $fileNameOnly = str_replace('.php', '', $file->getFilename());

                // merge the config file
                $this->mergeConfigFrom($file->getPathname(), $fileNameOnly);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }
    }
}


1			<?php
2
3			namespace App\Port\Config\Loaders;
4
5			use App;
6			use App\Port\Butler\Portals\Facade\PortButler;
7			use DB;
8			use File;
9			use Log;
10
11			/**
12			* Class ConfigsLoaderTrait.
13			*
14			* @author Mahmoud Zalt <[email protected]>
15			*/
16			trait ConfigsLoaderTrait
17			{
18
19			/**
20			* Auto load Containers and Port config files into Laravel
21			*/
22			public function autoLoadConfigFiles()
23			{
24			$this->autoLoadContainersConfigFiles();
25			$this->autoLoadPortConfigFiles();
26			}
27
28			protected function autoLoadContainersConfigFiles()
29			{
30			foreach (PortButler::getContainersNames() as $containerName) {
31			$this->loadConfigs(base_path('app/Containers/' . $containerName . '/Configs'));
32			}
33			}
34
35			protected function autoLoadPortConfigFiles()
36			{
37			$this->loadConfigs(base_path('app/Port/Config/Configs'));
38			}
39
40			/**
41			* @param $directory
42			*/
43			private function loadConfigs($directory)
44			{
45			if (File::isDirectory($directory)) {
46
47			$files = File::allFiles($directory);
48
49			foreach ($files as $file) {
50			// build the key from the file name (just remove the .php extension from the file name)
51			$fileNameOnly = str_replace('.php', '', $file->getFilename());
52
53			// merge the config file
54			$this->mergeConfigFrom($file->getPathname(), $fileNameOnly);
			0 ignored issues – show Bug introduced 2016-10-26 20:33 UTC by Report Bug Copy Issue Report It seems like `mergeConfigFrom()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
55			}
56			}
57			}
58			}
59

Porto-SAP / Hello-API

Push — master ( 390c77...fb089c )

ConfigsLoaderTrait::loadConfigs() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like