Controller - Code Metrics - Inspection of "remove all policies and replace them with permissi..." - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c5bf06...fa7b60 )

by Mahmoud

created 2016-12-30 15:25 UTC

Controller A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
wmc	6
c	0
b	0
f	0
lcom	1
cbo	5
dl	0
loc	56
rs	10

4 Methods

Rating	Name	Size	Complexity
A	showLoginPage()	4	1
A	loginAdmin()	14	3
A	viewDashboardPage()	4	1
A	logoutAdmin()	6	1

<?php

namespace App\Containers\Authentication\UI\WEB\Controllers;

use App\Containers\Authentication\Actions\WebAdminLoginAction;
use App\Containers\Authentication\Actions\WebLogoutAction;
use App\Containers\Authentication\UI\WEB\Requests\LoginRequest;
use App\Containers\Authentication\UI\WEB\Requests\ViewDashboardRequest;
use App\Port\Controller\Abstracts\PortWebController;

use App\Containers\Authentication\Exceptions\AuthenticationFailedException;

/**
 * Class Controller
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class Controller extends PortWebController
{

    /**
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showLoginPage()
    {
        return view('login');
    }

    /**
     * @param \App\Containers\Authentication\UI\WEB\Requests\LoginRequest $request
     * @param \App\Containers\Authentication\Actions\WebAdminLoginAction  $action
     *
     * @return  $this|\Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function loginAdmin(LoginRequest $request, WebAdminLoginAction $action)
    {
        try {
            $result = $action->run($request->email, $request->password, $request->remember_me);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } catch (AuthenticationFailedException $e) {
            return redirect('/login')->with('status', $e->message);
        }

        if (is_array($result)) {
            return redirect('/login')->with($result);
        }

        return redirect('/dashboard');
    }

    /**
     * @param \App\Containers\Authentication\UI\WEB\Requests\ViewDashboardRequest $request
     *
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function viewDashboardPage(ViewDashboardRequest $request)

    {
        return view('dashboard');
    }

    /**
     * @param \App\Containers\Authentication\Actions\WebLogoutAction $action
     *
     * @return  \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function logoutAdmin(WebLogoutAction $action)
    {
        $action->run();

        return view('login');
    }


}


1			<?php
2
3			namespace App\Containers\Authentication\UI\WEB\Controllers;
4
5			use App\Containers\Authentication\Actions\WebAdminLoginAction;
6			use App\Containers\Authentication\Actions\WebLogoutAction;
7			use App\Containers\Authentication\UI\WEB\Requests\LoginRequest;
8			use App\Containers\Authentication\UI\WEB\Requests\ViewDashboardRequest;
9			use App\Port\Controller\Abstracts\PortWebController;
10
11			use App\Containers\Authentication\Exceptions\AuthenticationFailedException;
12
13			/**
14			* Class Controller
15			*
16			* @author Mahmoud Zalt <[email protected]>
17			*/
18			class Controller extends PortWebController
19			{
20
21			/**
22			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
23			*/
24			public function showLoginPage()
25			{
26			return view('login');
27			}
28
29			/**
30			* @param \App\Containers\Authentication\UI\WEB\Requests\LoginRequest $request
31			* @param \App\Containers\Authentication\Actions\WebAdminLoginAction $action
32			*
33			* @return $this\|\Illuminate\Contracts\View\Factory\|\Illuminate\View\View
34			*/
35			public function loginAdmin(LoginRequest $request, WebAdminLoginAction $action)
36			{
37			try {
38			$result = $action->run($request->email, $request->password, $request->remember_me);
			0 ignored issues – show Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `email` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `password` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-09-09 20:46 UTC by Report Bug Copy Issue Report The property `remember_me` does not exist on `object<App\Containers\Au...\Requests\LoginRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
39			} catch (AuthenticationFailedException $e) {
40			return redirect('/login')->with('status', $e->message);
41			}
42
43			if (is_array($result)) {
44			return redirect('/login')->with($result);
45			}
46
47			return redirect('/dashboard');
48			}
49
50			/**
51			* @param \App\Containers\Authentication\UI\WEB\Requests\ViewDashboardRequest $request
52			*
53			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
54			*/
55			public function viewDashboardPage(ViewDashboardRequest $request)
			0 ignored issues – show Unused Code introduced 2016-12-30 15:28 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
56			{
57			return view('dashboard');
58			}
59
60			/**
61			* @param \App\Containers\Authentication\Actions\WebLogoutAction $action
62			*
63			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
64			*/
65			public function logoutAdmin(WebLogoutAction $action)
66			{
67			$action->run();
68
69			return view('login');
70			}
71
72
73			}
74

Porto-SAP / Hello-API

Push — master ( c5bf06...fa7b60 )

Controller A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like