FindUserAction::run() - Code Metrics - Inspection of "refactor the refresh user token" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e089fb...e812a5 )

by Mahmoud

created 2016-08-17 18:35 UTC

FindUserAction::run() B

↳ Parent: FindUserAction

Complexity

Conditions	5
Paths	8

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	20
rs	8.8571
cc	5
eloc	12
nc	8
nop	3

<?php

namespace App\Containers\User\Actions;

use App\Containers\User\Exceptions\UserNotFoundException;
use App\Containers\User\Tasks\FindUserByIdTask;
use App\Containers\User\Tasks\FindUserByVisitorIdTask;
use App\Containers\User\Tasks\GetAuthenticatedUserTask;
use App\Port\Action\Abstracts\Action;

/**
 * Class FindUserAction.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class FindUserAction extends Action
{

    /**
     * @var  \App\Containers\User\Tasks\FindUserByVisitorIdTask
     */
    private $findUserByVisitorIdTask;

    /**
     * @var  \App\Containers\User\Tasks\GetAuthenticatedUserTask
     */
    private $getAuthenticatedUserTask;

    /**
     * FindUserByAnythingAction constructor.
     *
     * @param \App\Containers\User\Tasks\FindUserByVisitorIdTask  $findUserByVisitorIdTask
     * @param \App\Containers\User\Tasks\FindUserByIdTask         $findUserByIdTask
     * @param \App\Containers\User\Tasks\GetAuthenticatedUserTask $getAuthenticatedUserTask
     */
    public function __construct(
        FindUserByVisitorIdTask $findUserByVisitorIdTask,
        FindUserByIdTask $findUserByIdTask,
        GetAuthenticatedUserTask $getAuthenticatedUserTask
    ) {
        $this->findUserByVisitorIdTask = $findUserByVisitorIdTask;
        $this->findUserByIdTask = $findUserByIdTask;
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->getAuthenticatedUserTask = $getAuthenticatedUserTask;
    }

    /**
     * @param $userId
     * @param $visitorId
     * @param $token
     *
     * @return  mixed
     */
    public function run($userId, $visitorId, $token)
    {
        if ($userId) {
            $user = $this->findUserByIdTask->run($userId);
        } else {
            if ($token) {
                $user = $this->getAuthenticatedUserTask->run();
            } else {
                if ($visitorId) {
                    $user = $this->findUserByVisitorIdTask->run($visitorId);
                }
            }
        }

        if (!$user) {
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            throw new UserNotFoundException();
        }

        return $user;
    }

}


1			<?php
2
3			namespace App\Containers\User\Actions;
4
5			use App\Containers\User\Exceptions\UserNotFoundException;
6			use App\Containers\User\Tasks\FindUserByIdTask;
7			use App\Containers\User\Tasks\FindUserByVisitorIdTask;
8			use App\Containers\User\Tasks\GetAuthenticatedUserTask;
9			use App\Port\Action\Abstracts\Action;
10
11			/**
12			* Class FindUserAction.
13			*
14			* @author Mahmoud Zalt <[email protected]>
15			*/
16			class FindUserAction extends Action
17			{
18
19			/**
20			* @var \App\Containers\User\Tasks\FindUserByVisitorIdTask
21			*/
22			private $findUserByVisitorIdTask;
23
24			/**
25			* @var \App\Containers\User\Tasks\GetAuthenticatedUserTask
26			*/
27			private $getAuthenticatedUserTask;
28
29			/**
30			* FindUserByAnythingAction constructor.
31			*
32			* @param \App\Containers\User\Tasks\FindUserByVisitorIdTask $findUserByVisitorIdTask
33			* @param \App\Containers\User\Tasks\FindUserByIdTask $findUserByIdTask
34			* @param \App\Containers\User\Tasks\GetAuthenticatedUserTask $getAuthenticatedUserTask
35			*/
36			public function __construct(
37			FindUserByVisitorIdTask $findUserByVisitorIdTask,
38			FindUserByIdTask $findUserByIdTask,
39			GetAuthenticatedUserTask $getAuthenticatedUserTask
40			) {
41			$this->findUserByVisitorIdTask = $findUserByVisitorIdTask;
42			$this->findUserByIdTask = $findUserByIdTask;
			0 ignored issues – show Bug introduced 2016-08-17 17:49 UTC by Report Bug Copy Issue Report The property `findUserByIdTask` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
43			$this->getAuthenticatedUserTask = $getAuthenticatedUserTask;
44			}
45
46			/**
47			* @param $userId
48			* @param $visitorId
49			* @param $token
50			*
51			* @return mixed
52			*/
53			public function run($userId, $visitorId, $token)
54			{
55			if ($userId) {
56			$user = $this->findUserByIdTask->run($userId);
57			} else {
58			if ($token) {
59			$user = $this->getAuthenticatedUserTask->run();
60			} else {
61			if ($visitorId) {
62			$user = $this->findUserByVisitorIdTask->run($visitorId);
63			}
64			}
65			}
66
67			if (!$user) {
			0 ignored issues – show Bug introduced 2016-08-17 18:38 UTC by Report Bug Copy Issue Report The variable `$user` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
68			throw new UserNotFoundException();
69			}
70
71			return $user;
72			}
73
74			}
75

Porto-SAP / Hello-API

Push — master ( e089fb...e812a5 )

FindUserAction::run() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like