Porto-SAP / Hello-API

app/Containers/Authorization/UI/API/Tests/Functional/AttachPermissionsToRoleTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App\Containers\Authorization\Models\Permission;
 use App\Containers\Authorization\Models\Role;
-use App\Containers\User\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
 
 /**

app/Containers/Authorization/UI/API/Tests/Functional/FindPermissionByNameTest.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 namespace App\Containers\Order\UI\API\Tests\Functional;
 
 use App\Containers\Order\Models\Order;
-use App\Containers\Invoice\Models\Invoice;
-use App\Containers\User\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
-use Vinkla\Hashids\Facades\Hashids;
 
 /**
  * Class FindRoleByNameTest.

app/Containers/Authorization/UI/API/Tests/Functional/ListPermissionsTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Containers\Authorization\UI\API\Tests\Functional;
 
-use App\Containers\Authorization\Models\User;
 use App\Port\Tests\PHPUnit\Abstracts\TestCase;
 
 /**

app/Containers/Authorization/Tasks/AttachPermissionsToRoleTask.php

Spacing +3 added lines, -3 removed lines

@@ -42,13 +42,13 @@
     {
         $role = $this->getRoleAction->run($roleName);
 
-        if(is_array($permissionNames)){
+        if (is_array($permissionNames)) {
 
-            foreach ($permissionNames as $permissionName){
+            foreach ($permissionNames as $permissionName) {
                 $role->givePermissionTo($permissionName);
             }
 
-        }else{
+        } else {
             $role->givePermissionTo($permissionNames);
         }
 

Braces +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
                 $this->attachRole($user, $role);
             }
 
-        }else{
+        } else{
             $this->attachRole($user, $roles);
         }
 

app/Containers/Authentication/Actions/WebAdminLoginAction.php

Spacing +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     {
         $user = $this->webLoginTask->run($email, $password, $remember);
 
-        if($user){
+        if ($user) {
             $this->isUserAdminTask->run($user);
         }
 

app/Port/Tests/PHPUnit/Traits/TestingTrait.php

Doc Comments +6 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
     public $loggedInTestingUser;
 
     /**
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param string $verb
      * @param array  $data
      * @param bool   $protected
@@ -110,7 +110,7 @@ 
      * So this can be used to test endpoints that are protected by visitors
      * access.
      *
-     * @return  App\Containers\User\Models\User|mixed
+     * @return  User
      */
     public function getVisitor()
     {
@@ -124,7 +124,7 @@ 
     }
 
     /**
-     * @return  App\Containers\User\Models\User|mixed
+     * @return  User
      */
     public function getLoggedInTestingAdmin()
     {
@@ -162,7 +162,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingUser($userDetails = null)
     {
@@ -193,7 +193,7 @@ 
     /**
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingAdmin($userDetails = null)
     {
@@ -209,7 +209,7 @@ 
      *
      * @param null $userDetails
      *
-     * @return  mixed
+     * @return  User
      */
     public function registerAndLoginTestingDeveloper($userDetails = null)
     {

Spacing +2 added lines, -2 removed lines

@@ -381,7 +381,7 @@ 
      */
     public static function getTestingFile($fileName, $stubDirPath, $mimeType = null, $size = null)
     {
-        $file =  $stubDirPath . $fileName;
+        $file = $stubDirPath . $fileName;
 
         return new UploadedFile($file, $fileName, $mimeType, $size, $error = null, $testMode = true);
     }
@@ -418,7 +418,7 @@ 
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Containers/Application/Middlewares/ApplicationAuthentication.php

Spacing +2 added lines, -2 removed lines

@@ -93,7 +93,7 @@ 
 
         $token = str_replace('Bearer ', '', $request->header('authorization'));
 
-        if(!$token){
+        if (!$token) {
             throw new AuthenticationFailedException('Empty Token!');
         }
 
@@ -113,7 +113,7 @@ 
                 throw new UserNotPermittedException();
             }
 
-        }else{
+        } else {
             return (App::make(\Dingo\Api\Http\Middleware\Auth::class))->handle($request, $next);
             // another way to do handle this is by calling `$user = $this->jwtAuthAdapter->toUser($token);`
             // and continuing the execution of this code till the last return, but to maintain consistency

Braces +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
                 $this->attachRole($user, $role);
             }
 
-        }else{
+        } else{
             $this->attachRole($user, $roles);
         }