Porto-SAP / Hello-API

app/Containers/Stripe/Tests/Unit/ChargeUsersTest.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use App\Containers\Stripe\Tasks\CreateStripeAccountObjectTask;
 use App\Containers\Stripe\Tasks\ChargeWithStripeTask;
 use App\Containers\Stripe\Tests\TestCase;
-use App\Ship\Features\Payment\Proxies\PaymentsProxy;
 use Illuminate\Support\Facades\App;
 
 /**

app/Ship/Features/Payment/Proxies/PaymentsProxy.php

Doc Comments +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
     }
 
     /**
-     * @param $object
+     * @param ChargeableInterface $object
      *
      * @return  null
      */
@@ -47,7 +47,7 @@ 
     }
 
     /**
-     * @param $object
+     * @param ChargeableInterface $object
      *
      * @return  null
      */

app/Ship/Parents/Exceptions/Exception.php

Doc Comments +2 added lines, -2 removed lines

@@ -112,9 +112,9 @@
 
 
     /**
-     * @param $statusCode
+     * @param integer $statusCode
      * @param $message
-     * @param $code
+     * @param integer $code
      */
     private function logTheError($statusCode, $message, $code)
     {

app/Ship/Features/Tests/PhpUnit/TestsAuthHelperTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -154,7 +154,7 @@
     }
 
     /**
-     * @param $user
+     * @param User $user
      * @param $access
      *
      * @return  mixed

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use App;
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
 use App\Containers\User\Models\User;
-use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Support\Facades\Hash;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
      */
     private function findOrCreateTestingUser($userDetails, $access)
     {
-        return $this->testingUser ? : $this->createTestingUser($userDetails, $access);
+        return $this->testingUser ?: $this->createTestingUser($userDetails, $access);
     }
 
     /**
@@ -126,7 +126,7 @@ 
         ];
 
         // if no user detail provided, use the default details, to find the password or generate one before encoding it
-        return $this->prepareUserPassword($userDetails ? : $defaultUserDetails);;
+        return $this->prepareUserPassword($userDetails ?: $defaultUserDetails); ;
     }
 
     /**
@@ -161,7 +161,7 @@ 
      */
     private function setupTestingUserAccess($user, $access)
     {
-        $access = $access ? : $this->getAccess();
+        $access = $access ?: $this->getAccess();
 
         $user = $this->setupTestingUserPermissions($user, $access);
         $user = $this->setupTestingUserRoles($user, $access);

app/Ship/Features/Tests/PhpUnit/TestsRequestHelperTrait.php

Doc Comments +3 added lines, -5 removed lines

@@ -63,9 +63,7 @@ 
 
     /**
      * @param        $this ->endpointUrl
-     * @param string $this ->endpointVerb
      * @param array  $data
-     * @param bool   $protected
      * @param array  $headers
      *
      * @return  mixed
@@ -91,7 +89,7 @@ 
      * @param bool   $skipEncoding
      * @param string $replace
      *
-     * @return  mixed
+     * @return  TestsRequestHelperTrait
      */
     public function injectId($id, $skipEncoding = false, $replace = '{id}')
     {
@@ -108,7 +106,7 @@ 
      *
      * to be used as follow: $this->endpoint('verb@url')->makeCall($data);
      *
-     * @param $endpoint
+     * @param string $endpoint
      *
      * @return  $this
      */
@@ -282,7 +280,7 @@ 
     }
 
     /**
-     * @param $separator
+     * @param string $separator
      */
     private function validateEndpointFormat($separator)
     {

app/Ship/Features/Tests/PhpUnit/TestsResponseHelperTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $httpResponse
      */
     public function assertResponseContainKeys($keys, $httpResponse)

app/Ship/Parents/Tests/PhpUnit/TestCase.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace App\Ship\Parents\Tests\PhpUnit;
 
-use App\Ship\Features\Tests\PhpUnit\TestingTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsAuthHelperTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsCustomHelperTrait;
 use App\Ship\Features\Tests\PhpUnit\TestsMockHelperTrait;

app/Containers/User/Data/Factories/UserFactory.php

Spacing +1 added lines, -1 removed lines

@@ -2,7 +2,7 @@
 
 use Illuminate\Support\Facades\Hash;
 
-$factory->define(App\Containers\User\Models\User::class, function (Faker\Generator $faker) {
+$factory->define(App\Containers\User\Models\User::class, function(Faker\Generator $faker) {
 
     return [
         'name'     => $faker->name,

app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
             return;
         }
 
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);