FindUserByAnythingAction::run() - Code Metrics - Inspection of "refactor the find user action" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6fd8a2...c6c9a2 )

by Mahmoud

created 2016-08-10 11:42 UTC

FindUserByAnythingAction::run() A

↳ Parent: FindUserByAnythingAction

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
rs	9.2
cc	4
eloc	10
nc	4
nop	3

<?php

namespace App\Containers\User\Actions;

use App\Containers\User\Services\FindUserService;
use App\Port\Action\Abstracts\Action;
use Illuminate\Support\Facades\Auth;

/**
 * Class FindUserByAnythingAction.
 *
 * @author Mahmoud Zalt <[email protected]>
 */
class FindUserByAnythingAction extends Action
{

    /**
     * @var  \App\Containers\User\Services\FindUserService
     */
    private $findUserService;

    /**
     * FindUserByAnythingAction constructor.
     *
     * @param \App\Containers\User\Services\FindUserService $findUserService
     */
    public function __construct(
        FindUserService $findUserService
    ) {
        $this->findUserService = $findUserService;
    }

    /**
     * @param $userId
     * @param $visitorId
     * @param $token
     *
     * @return  mixed
     */
    public function run($userId, $visitorId, $token)
    {
        if ($userId) {
            $user = $this->findUserService->byId($userId);
        } else {
            if ($token) {
                $user = Auth::user();
            } else {
                if ($visitorId) {
                    $user = $this->findUserService->byVisitorId($visitorId);
                }
            }
        }

        return $user;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

}


1			<?php
2
3			namespace App\Containers\User\Actions;
4
5			use App\Containers\User\Services\FindUserService;
6			use App\Port\Action\Abstracts\Action;
7			use Illuminate\Support\Facades\Auth;
8
9			/**
10			* Class FindUserByAnythingAction.
11			*
12			* @author Mahmoud Zalt <[email protected]>
13			*/
14			class FindUserByAnythingAction extends Action
15			{
16
17			/**
18			* @var \App\Containers\User\Services\FindUserService
19			*/
20			private $findUserService;
21
22			/**
23			* FindUserByAnythingAction constructor.
24			*
25			* @param \App\Containers\User\Services\FindUserService $findUserService
26			*/
27			public function __construct(
28			FindUserService $findUserService
29			) {
30			$this->findUserService = $findUserService;
31			}
32
33			/**
34			* @param $userId
35			* @param $visitorId
36			* @param $token
37			*
38			* @return mixed
39			*/
40			public function run($userId, $visitorId, $token)
41			{
42			if ($userId) {
43			$user = $this->findUserService->byId($userId);
44			} else {
45			if ($token) {
46			$user = Auth::user();
47			} else {
48			if ($visitorId) {
49			$user = $this->findUserService->byVisitorId($visitorId);
50			}
51			}
52			}
53
54			return $user;
			0 ignored issues – show Bug introduced 2016-08-10 10:37 UTC by Report Bug Copy Issue Report The variable `$user` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
55			}
56
57			}
58

Porto-SAP / Hello-API

Push — master ( 6fd8a2...c6c9a2 )

FindUserByAnythingAction::run() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like