Porto-SAP / Hello-API

app/Ship/Engine/Loaders/ConsolesLoaderTrait.php

Doc Comments +1 added lines

@@ -39,6 +39,7 @@
 
     /**
      * @param $consoleClass
+     * @param string $directory
      */
     private function loadTheConsoles($directory)
     {

app/Ship/Engine/Loaders/ProvidersLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -38,7 +38,7 @@
     }
 
     /**
-     * @param $directory
+     * @param string $directory
      */
     private function loadProviders($directory)
     {

app/Ship/Engine/Loaders/RoutesLoaderTrait.php

Doc Comments +1 added lines, -1 removed lines

@@ -113,7 +113,7 @@
     /**
      * @param \Symfony\Component\Finder\SplFileInfo $file
      *
-     * @return  mixed
+     * @return  string
      */
     private function getRouteFileNameWithoutExtension(SplFileInfo $file)
     {

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
                 $apiVersionNumber = $this->getRouteFileVersionNumber($file);
 
                 $this->apiRouter->version('v' . $apiVersionNumber,
-                    function (DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
+                    function(DingoApiRouter $router) use ($file, $containerPath, $containersNamespace) {
 
                         $controllerNamespace = $containersNamespace . '\\Containers\\' . basename($containerPath) . '\\UI\API\Controllers';
 
@@ -67,7 +67,7 @@ 
                             'limit'      => Config::get('hello.api.limit'),
                             // The API limit expiry time.
                             'expires'    => Config::get('hello.api.limit_expires'),
-                        ], function ($router) use ($file) {
+                        ], function($router) use ($file) {
 
                             require $file->getPathname();
 
@@ -101,7 +101,7 @@ 
                 $this->webRouter->group([
                     'middleware' => ['web'],
                     'namespace'  => $controllerNamespace,
-                ], function (LaravelRouter $router) use ($file) {
+                ], function(LaravelRouter $router) use ($file) {
                     require $file->getPathname();
                 });
             }

app/Ship/Engine/Loaders/SeederLoaderTrait.php

Doc Comments +4 added lines, -4 removed lines

@@ -70,8 +70,8 @@ 
     }
 
     /**
-     * @param array $directories
-     * @param       $seedersClasses
+     * @param string[] $directories
+     * @param       Collection $seedersClasses
      *
      * @return  mixed
      */
@@ -103,7 +103,7 @@ 
     /**
      * @param $seedersClasses
      *
-     * @return  \Illuminate\Support\Collection|static
+     * @return  Collection|null
      */
     private function sortSeeders($seedersClasses)
     {
@@ -140,7 +140,7 @@ 
     }
 
     /**
-     * @param $seedersClasses
+     * @param Collection|null $seedersClasses
      */
     private function loadSeeders($seedersClasses)
     {

Spacing +1 added lines, -1 removed lines

@@ -122,7 +122,7 @@
             }
 
             // sort the classes that needed to be ordered
-            $orderedSeederClasses = $orderedSeederClasses->sortBy(function ($seederFullClassName) {
+            $orderedSeederClasses = $orderedSeederClasses->sortBy(function($seederFullClassName) {
                 // get the order number form the end of each class name
                 $orderNumber = substr($seederFullClassName, strpos($seederFullClassName, "_") + 1);
 

app/Ship/Features/Tests/PhpUnit/GeneralTestsHelpersTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -70,7 +70,7 @@ 
      *
      * Example: you give it ('users/{id}/stores', 100) it returns 'users/100/stores'
      *
-     * @param        $endpoint
+     * @param        string $endpoint
      * @param        $id
      * @param bool   $skipEncoding
      * @param string $replace
@@ -192,7 +192,7 @@ 
     }
 
     /**
-     * @param $keys
+     * @param string[] $keys
      * @param $response
      */
     public function assertResponseContainKeys($keys, $response)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace App\Ship\Features\Tests\PhpUnit;
 
 use App;
-use Artisan;
 use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Http\Response;
 use Illuminate\Http\UploadedFile;

app/Ship/Features/Tests/PhpUnit/TestingUserTrait.php

Unused Use Statements -2 removed lines

@@ -5,8 +5,6 @@
 use App;
 use App\Containers\Authentication\Tasks\ApiLoginThisUserObjectTask;
 use App\Containers\User\Models\User;
-use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 use Illuminate\Support\Facades\Hash;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
     public function createTestingUser($access = null, $userDetails = null)
     {
         // if no user detail provided, use the default details.
-        $userDetails = $userDetails ? : [
+        $userDetails = $userDetails ?: [
             'name'     => 'Testing User',
             'email'    => $this->faker->email,
             'password' => 'testing-pass',
@@ -112,7 +112,7 @@ 
         ]);
 
         // assign roles and permissions
-        $user = $this->setupTestingUserAccess($user, $access ? : (isset($this->access) ? $this->access : null));
+        $user = $this->setupTestingUserAccess($user, $access ?: (isset($this->access) ? $this->access : null));
 
         // log the user in
         $user = App::make(ApiLoginThisUserObjectTask::class)->run($user);

app/Ship/Parents/Tests/PhpUnit/TestCase.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App\Ship\Features\Tests\PhpUnit\CustomTestsHelpersTrait;
 use App\Ship\Features\Tests\PhpUnit\GeneralTestsHelpersTrait;
-use App\Ship\Features\Tests\PhpUnit\TestingTrait;
 use App\Ship\Features\Tests\PhpUnit\TestingUserTrait;
 use Faker\Generator;
 use Illuminate\Contracts\Console\Kernel as LaravelKernel;

app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use App;
 use Artisan;
-use Dingo\Api\Http\Response as DingoAPIResponse;
 
 /**
  * Class TestCaseTrait

Spacing +1 added lines, -1 removed lines

@@ -418,7 +418,7 @@
      */
     public function overrideSubDomain($subDomain, $url = null)
     {
-        $url = ($url) ? : $this->baseUrl;
+        $url = ($url) ?: $this->baseUrl;
 
         $info = parse_url($url);
 

app/Ship/Engine/Loaders/FactoriesLoaderTrait.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
     {
         $newFactoriesPath = '/app/Ship/Engine/Loaders/FactoryMixer';
 
-        App::singleton(Factory::class, function ($app) use ($newFactoriesPath) {
+        App::singleton(Factory::class, function($app) use ($newFactoriesPath) {
             $faker = $app->make(Generator::class);
 
             return Factory::construct($faker, base_path() . $newFactoriesPath);