CreatePaypalAccountObjectTask::run() - Code Metrics - Inspection of "remove the paypal action" - Porto-SAP/Hello-API - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( bb09ea...2c6af0 )

by Mahmoud

created 2016-08-18 11:27 UTC

CreatePaypalAccountObjectTask::run() A

↳ Parent: CreatePaypalAccountObjectTask

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
rs	9.4285
cc	1
eloc	6
nc	1
nop	2

<?php

namespace App\Containers\Paypal\Tasks;

use App\Containers\Paypal\Data\Repositories\PaypalAccountRepository;
use App\Containers\Paypal\Models\PaypalAccount;
use App\Containers\User\Models\User;
use App\Port\Action\Abstracts\Action;
use Auth;

/**
 * Class CreatePaypalAccountObjectTask
 *
 * @author  Mahmoud Zalt  <[email protected]>
 */
class CreatePaypalAccountObjectTask extends Action
{

    /**
     * @var  \App\Containers\Paypal\Data\Repositories\PaypalAccountRepository
     */
    private $paypalAccountRepository;

    /**
     * CreatePaypalAccountTask constructor.
     *
     * @param \App\Containers\Paypal\Data\Repositories\PaypalAccountRepository $paypalAccountRepository
     */
    public function __construct(PaypalAccountRepository $paypalAccountRepository)
    {
        $this->paypalAccountRepository = $paypalAccountRepository;
    }

    /**
     * Create paypal account in my database
     *
     * @param \App\Containers\User\Models\User $user
     * @param                                  $some_id
     *
     * @return  \App\Containers\Paypal\Models\PaypalAccount|mixed
     */
    public function run(User $user, $some_id)
    {
        $paypalAccount = new PaypalAccount();
        $paypalAccount->some_id = $some_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $paypalAccount->user()->associate($user);

        $paypalAccount = $this->paypalAccountRepository->create($paypalAccount->toArray());

        return $paypalAccount;
    }

}


1			<?php
2
3			namespace App\Containers\Paypal\Tasks;
4
5			use App\Containers\Paypal\Data\Repositories\PaypalAccountRepository;
6			use App\Containers\Paypal\Models\PaypalAccount;
7			use App\Containers\User\Models\User;
8			use App\Port\Action\Abstracts\Action;
9			use Auth;
10
11			/**
12			* Class CreatePaypalAccountObjectTask
13			*
14			* @author Mahmoud Zalt <[email protected]>
15			*/
16			class CreatePaypalAccountObjectTask extends Action
17			{
18
19			/**
20			* @var \App\Containers\Paypal\Data\Repositories\PaypalAccountRepository
21			*/
22			private $paypalAccountRepository;
23
24			/**
25			* CreatePaypalAccountTask constructor.
26			*
27			* @param \App\Containers\Paypal\Data\Repositories\PaypalAccountRepository $paypalAccountRepository
28			*/
29			public function __construct(PaypalAccountRepository $paypalAccountRepository)
30			{
31			$this->paypalAccountRepository = $paypalAccountRepository;
32			}
33
34			/**
35			* Create paypal account in my database
36			*
37			* @param \App\Containers\User\Models\User $user
38			* @param $some_id
39			*
40			* @return \App\Containers\Paypal\Models\PaypalAccount\|mixed
41			*/
42			public function run(User $user, $some_id)
43			{
44			$paypalAccount = new PaypalAccount();
45			$paypalAccount->some_id = $some_id;
			0 ignored issues – show Documentation introduced 2016-08-18 11:21 UTC by Report Bug Copy Issue Report The property `some_id` does not exist on `object<App\Containers\Pa...l\Models\PaypalAccount>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46			$paypalAccount->user()->associate($user);
47
48			$paypalAccount = $this->paypalAccountRepository->create($paypalAccount->toArray());
49
50			return $paypalAccount;
51			}
52
53			}
54

Porto-SAP / Hello-API

Push — master ( bb09ea...2c6af0 )

CreatePaypalAccountObjectTask::run() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like