App\Ship\Engine\Loaders\ConsolesLoaderTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	46
Duplicated Lines	30.43 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	loadConsolesFromContainers()	0	6	1
A	loadConsolesFromShip()	0	6	1
A	loadTheConsoles()	14	17	3

<?php

namespace App\Ship\Engine\Loaders;

use App;
use App\Ship\Engine\Butlers\Facades\LoaderButler;
use File;

/**
 * Class ConsolesLoaderTrait.
 *
 * @author  Mahmoud Zalt <mahmoud@zalt.me>
 */
trait ConsolesLoaderTrait
{

    /**
     * @param $containerName
     */
    public function loadConsolesFromContainers($containerName)
    {
        $containerCommandsDirectory = base_path('app/Containers/' . $containerName . '/UI/CLI/Commands/');

        $this->loadTheConsoles($containerCommandsDirectory);
    }

    /**
     * @param $portFolderName
     */
    public function loadConsolesFromShip($portFolderName)

The parameter $portFolderName is not used and could be removed.

    {
//        $portFolderName = base_path('app/Ship/') . $portFolderName . '/Commands/';

47% of this comment could be valid code. Did you maybe forget this after debugging?

//
//        $this->loadTheConsoles($portFolderName);
    }

    /**
     * @param $consoleClass
     */
    private function loadTheConsoles($directory)
    {
        if (File::isDirectory($directory)) {

This code seems to be duplicated across your project.

            $files = File::allFiles($directory);

            foreach ($files as $consoleFile) {

                $consoleClass = LoaderButler::getClassFullNameFromFile($consoleFile->getPathname());

                // when user from the Main Service Provider, which extends Laravel
                // service provider you get access to `$this->commands`
                $this->commands([$consoleClass]);

It seems like commands() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }

        }
    }


}