Completed
Push — master ( 1c8f09...485292 )
by Mahmoud
06:58
created
app/Ship/Features/Tests/PhpUnit/TestsResponseHelperTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@
 block discarded – undo
61 61
     }
62 62
 
63 63
     /**
64
-     * @param $keys
64
+     * @param string[] $keys
65 65
      * @param $httpResponse
66 66
      */
67 67
     public function assertResponseContainKeys($keys, $httpResponse)
Please login to merge, or discard this patch.
app/Ship/Parents/Tests/PhpUnit/TestCase.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace App\Ship\Parents\Tests\PhpUnit;
4 4
 
5
-use App\Ship\Features\Tests\PhpUnit\TestingTrait;
6 5
 use App\Ship\Features\Tests\PhpUnit\TestsAuthHelperTrait;
7 6
 use App\Ship\Features\Tests\PhpUnit\TestsCustomHelperTrait;
8 7
 use App\Ship\Features\Tests\PhpUnit\TestsMockHelperTrait;
Please login to merge, or discard this patch.
app/Containers/User/Data/Factories/UserFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@
 block discarded – undo
2 2
 
3 3
 use Illuminate\Support\Facades\Hash;
4 4
 
5
-$factory->define(App\Containers\User\Models\User::class, function (Faker\Generator $faker) {
5
+$factory->define(App\Containers\User\Models\User::class, function(Faker\Generator $faker) {
6 6
 
7 7
     return [
8 8
         'name'     => $faker->name,
Please login to merge, or discard this patch.
app/Ship/Parents/Tests/PhpUnit/TestCaseTrait.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@
 block discarded – undo
32 32
             return;
33 33
         }
34 34
 
35
-        $url = ($url) ? : $this->baseUrl;
35
+        $url = ($url) ?: $this->baseUrl;
36 36
 
37 37
         $info = parse_url($url);
38 38
 
Please login to merge, or discard this patch.
app/Containers/User/UI/API/Tests/Functional/CreateAdminTest.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -38,10 +38,10 @@
 block discarded – undo
38 38
             'name'  => $data['name'],
39 39
         ], $response);
40 40
 
41
-         // assert response contain the token
41
+            // assert response contain the token
42 42
         $this->assertResponseContainKeys(['id', 'token'], $response);
43 43
 
44
-         // assert the data is stored in the database
44
+            // assert the data is stored in the database
45 45
         $this->seeInDatabase('users', ['email' => $data['email']]);
46 46
 
47 47
         $responseContent = $this->getResponseContent($response);
Please login to merge, or discard this patch.
app/Containers/Localization/Middlewares/Localization.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     }
52 52
 
53 53
     /**
54
-     * @param $lang
54
+     * @param string $lang
55 55
      *
56 56
      * @return string|Exception
57 57
      */
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
     }
68 68
 
69 69
     /**
70
-     * @param $request
70
+     * @param \Illuminate\Http\Request $request
71 71
      *
72 72
      * @return  string
73 73
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
     private function findLanguage($request)
75 75
     {
76 76
         // read the language from the request header, if the header is missed, take the default local language
77
-        return $request->header('Content-Language') ? : $this->app->config->get('app.locale');
77
+        return $request->header('Content-Language') ?: $this->app->config->get('app.locale');
78 78
     }
79 79
 
80 80
     /**
Please login to merge, or discard this patch.
app/Ship/Engine/Loaders/LocalizationLoader.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
             $paths[] = app_path() . "/Containers/{$containerName}/Resources/Languages";
36 36
         }
37 37
 
38
-        $this->app->singleton('translation.loader', function ($app) use ($paths){
38
+        $this->app->singleton('translation.loader', function($app) use ($paths){
39 39
             return new FileLoader($app['files'], $paths);
40 40
         });
41 41
     }
Please login to merge, or discard this patch.